Repository navigation
Move pointer out of viewport after mount in Playwright tests (#746) - #747
Merged
Merged
Conversation
Components are mounted in the top left corner of the viewport where the pointer rests, so Chromium applied `:hover` to them and snapshots captured form fields in their hover state or during the hover transition. The shared `test` from `tests/playwright` wraps the `mount` fixture to move the pointer out of the viewport after each mount. Snapshots that contained the hover state are regenerated.
Contributor
|
Contributor
Author
|
@claude, review this PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Components are mounted in the top left corner of the viewport where the pointer rests, so Chromium applied
:hoverto them and snapshots captured form fields in their hover state or during the hover transition.The shared
testfromtests/playwrightwraps themountfixture to move the pointer out of the viewport after each mount. Snapshots that contained the hover state are regenerated.Closes #746