Relocate manual .d.ts definitions under types_DEPRECATED/#57513
Open
huntie wants to merge 1 commit into
Open
Conversation
Summary: See [**RFC0894: Removing deep imports from react-native**](react-native-community/discussions-and-proposals#894) **Changes** Rename the hand-written `types/` directory to `types_DEPRECATED/` and consolidate the co-located `.d.ts` declarations beneath it. - This is a pure relocation with **no change** to the public type surface. The package `"exports"` map is updated so that every `types` condition resolves to the new location (`.` → `./types_DEPRECATED/index.d.ts`, `./Libraries/*` → `./types_DEPRECATED/Libraries/*.d.ts`) — consumers resolve the exact same types and runtime modules through the same import specifiers. - Relative imports between the moved declarations, and the references from the moved `types/` files into `Libraries/`, were rewritten so the type graph continues to resolve. **Downsides** Risk of structural code drift if/when source modules in `Libraries/` move around. **Counterpoint**: The aim here is to feature-lock the legacy JS API and remove deep `Libraries/` imports by projects. Changelog: [Internal] Differential Revision: D110602194
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110602194. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
See RFC0894: Removing deep imports from react-native
Changes
Rename the hand-written
types/directory totypes_DEPRECATED/and consolidate the co-located.d.tsdeclarations beneath it."exports"map is updated so that everytypescondition resolves to the new location (.→./types_DEPRECATED/index.d.ts,./Libraries/*→./types_DEPRECATED/Libraries/*.d.ts) — consumers resolve the exact same types and runtime modules through the same import specifiers.types/files intoLibraries/, were rewritten so the type graph continues to resolve.Downsides
Risk of structural code drift if/when source modules in
Libraries/move around.Counterpoint: The aim here is to feature-lock the legacy JS API and remove deep
Libraries/imports by projects.Changelog: [Internal]
Differential Revision: D110602194