Skip to content

fix: detect incomplete retrieval baseline comparisons - #316

Open
yashaskn8 wants to merge 1 commit into
reactome:mainfrom
yashaskn8:fix/retrieval-baseline-comparison
Open

yashaskn8 wants to merge 1 commit into
reactome:mainfrom
yashaskn8:fix/retrieval-baseline-comparison

Conversation

@yashaskn8

Copy link
Copy Markdown

Summary

The retrieval baseline comparison could report success even when questions, collections, or retriever results were missing. It also ignored additional entries in the newer capture.

This PR makes these structural differences visible and returns a nonzero exit status when captures are incomplete, while preserving the existing reporting for changed or reordered documents.

Changes

  • Detect missing and unexpected questions, collections, and retrievers.

  • Report structural mismatches and fail incomplete comparisons.

  • Add regression tests for structural differences, empty captures, document changes, and input immutability.
    Testing

  • Focused regression tests: 12 passed.

  • Retriever test suite: 104 passed, 1 skipped.

  • Ruff lint, formatting, and Git whitespace checks passed locally.

Contributes to #168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant