fix: correctly handle TLS identities for IP literals - #7
Open
M1k0t0 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix TLS endpoint identity handling when the configured host is a literal IPv4 or IPv6 address.
This change:
server_nameextension for IP literals.subjectAltName.iPAddressentries.Implementation
Uint8Array, no Node-onlynet.isIP()dependency is introduced.SERVER_NAMEextension when constructing a ClientHello for an IP reference.iPAddressSAN values separately fromdNSNameSAN values.Tests
Added coverage for:
iPAddressSAN matching.dNSNamefields.Also added the browser/JavaScriptCore bundle build to CI.
Type of change
Checklist:
Additional Notes:
The existing
cert/public-cert.pemtest certificate expired on July 29, 2026. This caused the existing localhost TLS integration test to fail certificate validity checks and eventually time out during the handshake.This PR renews that public test certificate using the repository's existing tracked test key while preserving its localhost identity and CA behavior. The renewed certificate is valid through August 2036.