AssertEqualsToSameRector: skip arrays whose actual value key order is not provably identical#727
Merged
Conversation
… not provably identical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9813.
assertEquals()compares arrays with==(key order ignored), whileassertSame()uses===(key order enforced). The rule narrowedassertEquals()→assertSame()on constant arrays after only inspecting the expected argument, so it broke passing tests whenever the actual value had the same pairs in a different order.Bad (before)
Good (after)
Narrowing now only happens when the actual value is also a constant array with the same keys in the same order:
Scalar (non-array) narrowing is unchanged.
Fix
shouldSkipConstantArrayType()now also receives the actual argument and skips unless it is aConstantArrayTypewhose key sequence matches the expected one (hasSameKeyOrder()).The old
assert_same_constant_arrayfixture (narrowed an unknown-orderarrayparam — the exact unsafe case reported) is replaced byskip_constant_array_unknown_actual, plus new fixtures for the different-order (skip) and same-order (narrow) cases.