Align CI rules - #94
Open
Krakabek wants to merge 5 commits into
Open
Conversation
added 2 commits
July 31, 2026 15:53
Add .github/workflows/ci.yaml matching the bare template, and add the test:types and test:unit scripts to package.json so the workflow's typecheck, lint, unit-test, and build steps all run. Built with Snoocode
added 3 commits
July 31, 2026 16:09
Bump the CI node-version from 22.6.0 to 22.20.0 so the build works: this template uses vite 8 / rolldown, which require node ^20.19.0 || >=22.12.0, so the build failed on 22.6.0 with a missing rolldown native binding. Also bump engines.node to >=22.12.0 to match, delete the committed package-lock.json, and gitignore it (the workflow uses npm install). Built with Snoocode
Built with Snoocode
The type-check script was removed but the deploy script still referenced it; update deploy to use test:types (identical tsc --build). Built with Snoocode
stephenoid
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Aligns this repo's CI to https://github.com/reddit/devvit-template-bare/blob/main/.github/workflows/ci.yaml
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks