-
Notifications
You must be signed in to change notification settings - Fork 14
feat: remove scalprum frontend support #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f40fdb4
45eb8a2
e652c51
1bf0495
6020721
1b29437
cb2492d
279c196
f7f74b7
b4f1b97
10e7f69
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
hopehadfield marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "name": "@red-hat-developer-hub/cli", | ||
| "description": "CLI for developing Backstage plugins and apps", | ||
| "version": "2.0.8", | ||
| "version": "2.1.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [high] semver-versioning Multiple backward-incompatible changes (five CLI options removed, output artifact format changed, hard errors for previously-valid Scalprum configurations, two commands removed) are shipped under a semver minor bump (2.0.8 → 2.1.0). The CHANGELOG (line 5) explicitly declares adherence to Semantic Versioning, which requires a MAJOR increment for any incompatible API change. Consumers resolving ^2.0.x or ~2.x will silently receive this breaking update. Suggested fix: Bump to 3.0.0 per the project's stated Semantic Versioning commitment. Update the CHANGELOG heading and README migration section to reference 3.0.0 accordingly. |
||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
|
|
@@ -51,51 +51,27 @@ | |
| "@backstage/release-manifests": "~0.0.13", | ||
| "@backstage/types": "~1.2.2", | ||
| "@manypkg/get-packages": "^1.1.3", | ||
| "@openshift/dynamic-plugin-sdk-webpack": "^3.0.0", | ||
| "@pmmmwh/react-refresh-webpack-plugin": "^0.6.0", | ||
| "@svgr/webpack": "^6.5.1", | ||
| "@yarnpkg/lockfile": "^1.1.0", | ||
| "@yarnpkg/parsers": "^3.0.0-rc.4", | ||
| "bfj": "^9.0.2", | ||
| "chalk": "^4.0.0", | ||
| "chokidar": "^3.3.1", | ||
| "codeowners": "^5.1.1", | ||
| "commander": "^9.1.0", | ||
| "css-loader": "^6.5.1", | ||
| "esbuild": "^0.28.1", | ||
| "esbuild-loader": "^4.0.0", | ||
| "eslint": "8.57.1", | ||
| "eslint-config-prettier": "^9.0.0", | ||
| "eslint-webpack-plugin": "^4.2.0", | ||
| "fork-ts-checker-webpack-plugin": "^9.0.0", | ||
| "fs-extra": "^11.2.0", | ||
| "gitconfiglocal": "2.1.0", | ||
| "handlebars": "^4.7.7", | ||
| "html-webpack-plugin": "~5.6.3", | ||
| "is-native-module": "^1.1.3", | ||
| "lodash": "^4.17.21", | ||
| "mini-css-extract-plugin": "^2.4.2", | ||
| "node-stdlib-browser": "^1.3.1", | ||
| "npm-packlist": "^5.0.0", | ||
| "ora": "^5.3.0", | ||
| "postcss": "^8.2.13", | ||
| "react-dev-utils": "^12.0.0-next.60", | ||
| "react-refresh": "^0.18.0", | ||
| "recursive-readdir": "^2.2.2", | ||
| "semver": "^7.5.4", | ||
| "style-loader": "^3.3.1", | ||
| "swc-loader": "^0.2.3", | ||
| "typescript": "5.4.5", | ||
| "typescript-json-schema": "^0.64.0", | ||
| "webpack": "~5.105.0", | ||
| "webpack-dev-server": "^5.0.0", | ||
| "yaml": "^2.5.1", | ||
| "yml-loader": "^2.1.0", | ||
| "yn": "^4.0.0" | ||
| "yaml": "^2.5.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@backstage/cli-module-test-jest": "0.1.3", | ||
| "@backstage/core-plugin-api": "~1.12.7", | ||
| "@backstage/eslint-plugin": "~0.3.1", | ||
| "@backstage/repo-tools": "~0.17.3", | ||
| "@jest/globals": "^30.0.0-beta.3", | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,18 +49,10 @@ export async function command(opts: OptionValues): Promise<void> { | |
| ]; | ||
| } else if (role === 'frontend-plugin' || role === 'frontend-plugin-module') { | ||
| targetPath = await frontend(roleInfo, opts); | ||
| configSchemaPaths = []; | ||
| if (fs.existsSync(path.join(targetPath, 'dist-scalprum'))) { | ||
| configSchemaPaths.push( | ||
| path.join(targetPath, 'dist-scalprum/configSchema.json'), | ||
| ); | ||
| } | ||
| if (fs.existsSync(path.join(targetPath, 'dist'))) { | ||
| configSchemaPaths.push(path.join(targetPath, 'dist/.config-schema.json')); | ||
| } | ||
| configSchemaPaths = [path.join(targetPath, 'dist/.config-schema.json')]; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] error-handling The guard if (fs.existsSync(path.join(targetPath, 'dist'))) that previously protected the config-schema write path was removed. The new code unconditionally assigns configSchemaPaths. If dist-dynamic/dist does not exist, fs.writeJson throws ENOENT because it does not create parent directories. Suggested fix: Use fs.outputJson instead of fs.writeJson, or add await fs.ensureDir(path.dirname(configSchemaPath)) before the write loop. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] error-handling-idiom The guard that previously protected the config-schema write path was removed. The new code unconditionally assigns Suggested fix: Use |
||
| } else { | ||
| throw new Error( | ||
| 'Only packages with the "backend-plugin", "backend-plugin-module" or "frontend-plugin" roles can be exported as dynamic backend plugins', | ||
| 'Only packages with the "backend-plugin", "backend-plugin-module", "frontend-plugin" or "frontend-plugin-module" roles can be exported as dynamic plugins', | ||
| ); | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[low] changelog-conventions
The 2.1.0 entry introduces a Migration section header that is not a standard Keep a Changelog section type. The CHANGELOG header (line 5) declares adherence to Keep a Changelog, whose standard types are: Added, Changed, Deprecated, Removed, Fixed, Security.
Suggested fix: Move the migration bullets into the existing Changed section, or add a Removed section for removed options/commands and fold the migration notes there.