Skip to content

fix(plugin-new): add Jest environment dependency - #204

Merged
gashcrumb merged 1 commit into
redhat-developer:mainfrom
gashcrumb:fix/plugin-new-jest-environment
Sep 15, 2026
Merged

gashcrumb merged 1 commit into
redhat-developer:mainfrom
gashcrumb:fix/plugin-new-jest-environment

Conversation

@gashcrumb

@gashcrumb gashcrumb commented Sep 15, 2026

Copy link
Copy Markdown
Member

Summary

  • add jest-environment-jsdom to generated plugin dev dependencies
  • cover the generated dependency in plugin new tests
  • prepare the 2.0.8 patch release

Verification

  • CI=true yarn backstage-cli package test
  • yarn tsc
  • yarn lint:check
  • yarn prettier:check
  • generated RHDH 2.1 backend plugin: yarn install && CI=true yarn test

Assisted-By: OpenCode
Signed-off-by: Stan Lewis <gashcrumb@gmail.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@sonarqubecloud

Copy link
Copy Markdown

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 15, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:09 PM UTC · Completed 1:20 PM UTC

Commit: 0c55cec · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-4-6 · Effort: high · Cost: $1.91

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Sep 15, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Small patch PR (7 files, 17 lines) adding a Jest dependency to plugin templates and covering it with tests; no protected paths, CI workflows, or security-sensitive changes touched, yielding a composite of 0.62x1.88 + 0.38x2.0 = 1.93, rounded to 2.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Sep 15, 2026

@PatAKnight PatAKnight left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gashcrumb
gashcrumb merged commit 74cc7b6 into redhat-developer:main Sep 15, 2026
69 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Sep 15, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 1:26 PM UTC · Completed 1:33 PM UTC

Commit: 0c55cec · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.90

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #204 — fix(plugin-new): add Jest environment dependency

Workflow: Human-authored fix PR by @gashcrumb → review agent (claude-sonnet-4-6, high effort, $1.91, ~11 min) → human review (@PatAKnight, "LGTM") → merged in ~16 minutes. No rework iterations.

Outcome: Clean workflow. The review agent correctly assessed this as a moderate-risk (2/5) change, approved without inline findings, and the human reviewer concurred. The change adds the missing jest-environment-jsdom dev dependency to three plugin templates, includes test coverage, bumps the version to 2.0.8, and updates CHANGELOG. All CI checks passed.

No new proposals filed. This workflow executed efficiently with appropriate outcomes at every stage.

Evidence for existing issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants