-
Notifications
You must be signed in to change notification settings - Fork 14
fix: recognize frontend feature loaders #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hopehadfield
wants to merge
1
commit into
redhat-developer:main
from
hopehadfield:fe-feature-loader-patch
+40
−11
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
.yarn/patches/@backstage-cli-node-npm-0.3.4-b80a6a686e.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| diff --git a/dist/index.d.ts b/dist/index.d.ts | ||
| index 8daae4886d170770fe6f04c267a920fd4c43d9cc..beac522b540649638f76cfccc3396ac05d159a6e 100644 | ||
| --- a/dist/index.d.ts | ||
| +++ b/dist/index.d.ts | ||
| @@ -401,7 +401,7 @@ declare class PackageRoles { | ||
| * | ||
| * @public | ||
| */ | ||
| -declare const packageFeatureType: readonly ["@backstage/BackendFeature", "@backstage/BackstagePlugin", "@backstage/FrontendPlugin", "@backstage/FrontendModule"]; | ||
| +declare const packageFeatureType: readonly ["@backstage/BackendFeature", "@backstage/BackstagePlugin", "@backstage/FrontendPlugin", "@backstage/FrontendModule", "@backstage/FrontendFeatureLoader"]; | ||
| /** | ||
| * @public | ||
| */ | ||
| diff --git a/dist/monorepo/PackageGraph.cjs.js b/dist/monorepo/PackageGraph.cjs.js | ||
| index 6599b1452af5c6026c8c267684a14622e635363c..7d6fee21357b6bb6376f98aa9ce6df2ac710cb98 100644 | ||
| --- a/dist/monorepo/PackageGraph.cjs.js | ||
| +++ b/dist/monorepo/PackageGraph.cjs.js | ||
| @@ -14,7 +14,8 @@ const packageFeatureType = [ | ||
| "@backstage/BackendFeature", | ||
| "@backstage/BackstagePlugin", | ||
| "@backstage/FrontendPlugin", | ||
| - "@backstage/FrontendModule" | ||
| + "@backstage/FrontendModule", | ||
| + "@backstage/FrontendFeatureLoader" | ||
| ]; | ||
| class PackageGraph extends Map { | ||
| /** | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] logic-error
The patch updates dist/monorepo/PackageGraph.cjs.js (CJS runtime) and dist/index.d.ts (type declarations) to add "@backstage/FrontendFeatureLoader", but contains no hunk for dist/monorepo/PackageGraph.js, which would be the ESM counterpart in a Rollup dual-build. If that file exists in the published @backstage/cli-node@0.3.4 tarball, ESM consumers will still see a 4-element packageFeatureType array without FrontendFeatureLoader at runtime while TypeScript compilation succeeds, masking the gap.
Suggested fix: Unpack the @backstage/cli-node@0.3.4 tarball and check for dist/monorepo/PackageGraph.js. If it exists, add a third hunk to the patch file targeting that file with the same "@backstage/FrontendFeatureLoader" addition to the packageFeatureType array.