-
Notifications
You must be signed in to change notification settings - Fork 14
docs(#206): add CLI UX design conventions to AGENTS.md #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fullsend-ai-coder
wants to merge
3
commits into
main
Choose a base branch
from
agent/206-cli-ux-conventions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−7
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
367eff7
docs: add CLI UX design conventions to AGENTS.md
fullsend-ai-coder[bot] ed59dd8
docs: update CLI examples to use positional entity refs
fullsend-ai-coder[bot] d6d8f88
docs: fix entity reference convention to cite resolveEntityWithAmbigu…
fullsend-ai-coder[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] correctness
The 'Entity references' convention claims entity refs are 'parsed by parseEntityRef / resolveEntityRef in kv.ts', but resolveEntityRef is never imported or called by any command file. All commands (api.ts, docs.ts, template.ts, catalog.ts) resolve entity refs via resolveEntityWithAmbiguityCheck from helpers.ts, which adds catalog-based ambiguity detection. A developer following this convention as written would call resolveEntityRef directly, bypassing ambiguity detection and producing inferior UX.
Suggested fix: Replace 'parsed by parseEntityRef / resolveEntityRef in kv.ts' with 'resolved via resolveEntityWithAmbiguityCheck from helpers.ts' (which internally calls parseEntityRef and adds catalog-based ambiguity detection).