-
Notifications
You must be signed in to change notification settings - Fork 14
feat(plugin-new): add local development support #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gashcrumb
wants to merge
8
commits into
redhat-developer:main
Choose a base branch
from
gashcrumb:feat/plugin-new-dev-harness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
de1c344
feat(plugin-new): add local dev harnesses
gashcrumb 3a0a2c5
docs(plugin-new): describe local dev harnesses
gashcrumb e25ae43
fix(plugin-new): use frontend dev app helper
gashcrumb 1961cc5
test(plugin-new): sort mock package versions
gashcrumb c33ffa1
feat(plugin-new): use JSX frontend template
gashcrumb 7d13730
fix(plugin-new): publish frontend federation assets
gashcrumb 6a8ef29
refactor(plugin-new): separate frontend entry facade
gashcrumb 87ccace
fix(plugin-new): align frontend package metadata
gashcrumb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { createBackend } from '@backstage/backend-defaults'; | ||
|
|
||
| const backend = createBackend(); | ||
|
|
||
| backend.add(import('../src')); | ||
| backend.start(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { createDevApp } from '@backstage/frontend-dev-utils'; | ||
|
|
||
| import plugin from '../src'; | ||
|
|
||
| createDevApp({ features: [plugin] }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| import React from 'react'; | ||
|
|
||
| export function PluginPage() { | ||
| return React.createElement('h1', undefined, '{{pluginId}}'); | ||
| return <h1>{{pluginId}}</h1>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1 @@ | ||
| import { createRouteRef } from '@backstage/core-plugin-api'; | ||
| import { createFrontendPlugin, PageBlueprint } from '@backstage/frontend-plugin-api'; | ||
| import React from 'react'; | ||
|
|
||
| const rootRouteRef = createRouteRef({ id: '{{pluginId}}' }); | ||
| const page = PageBlueprint.make({ | ||
| params: { | ||
| title: '{{pluginId}}', | ||
| path: '/{{pluginId}}', | ||
| routeRef: rootRouteRef, | ||
| loader: () => import('./PluginPage').then(m => React.createElement(m.PluginPage)), | ||
| }, | ||
| }); | ||
|
|
||
| export default createFrontendPlugin({ | ||
| pluginId: '{{pluginId}}', | ||
| extensions: [page], | ||
| routes: { root: rootRouteRef }, | ||
| }); | ||
| export { plugin as default } from './plugin'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { createRouteRef } from '@backstage/core-plugin-api'; | ||
| import { createFrontendPlugin, PageBlueprint } from '@backstage/frontend-plugin-api'; | ||
|
|
||
| const rootRouteRef = createRouteRef({ id: '{{pluginId}}' }); | ||
| const page = PageBlueprint.make({ | ||
| params: { | ||
| title: '{{pluginId}}', | ||
| path: '/{{pluginId}}', | ||
| routeRef: rootRouteRef, | ||
| loader: () => import('./PluginPage').then(m => <m.PluginPage />), | ||
| }, | ||
| }); | ||
|
|
||
| export const plugin = createFrontendPlugin({ | ||
|
gashcrumb marked this conversation as resolved.
|
||
| pluginId: '{{pluginId}}', | ||
| extensions: [page], | ||
| routes: { root: rootRouteRef }, | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.