Conversation
Yarn ignores gypfile:false and rebuilds any package that ships binding.gyp. Set dependenciesMeta.better-sqlite3.built=false so install uses the bundled prebuilds instead of node-gyp, which unblocks the cluster-free harness on images without a compiler toolchain. Ref: RHDHBUGS-3725 Signed-off-by: Jon Koops <jonkoops@gmail.com>
|
Contributor
|
The container image build workflow finished with status: |
Contributor
Author
|
Closing per author request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5403 +/- ##
=======================================
Coverage 63.68% 63.68%
=======================================
Files 121 121
Lines 2288 2288
Branches 527 527
=======================================
Hits 1457 1457
Misses 829 829
Partials 2 2
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #5359, cluster-free E2E fails on
yarn installbecause Yarn 4 runsnode-gypwhenever a dependency shipsbinding.gyp, even though better-sqlite3 13 bundles platform prebuilds and setsgypfile: falsefor npm (WiseLibs/better-sqlite3#1503).This adds
dependenciesMeta.better-sqlite3.built: false(same pattern askeytar) so Yarn skips the native build and loads the shipped prebuild at runtime.RHDHBUGS-3725