fix: disable yarn install scripts now that better-sqlite3 uses prebuilds - #5405
Merged
jonkoops merged 1 commit intoSep 15, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5405 +/- ##
==========================================
- Coverage 63.68% 59.69% -3.99%
==========================================
Files 121 109 -12
Lines 2288 2062 -226
Branches 527 501 -26
==========================================
- Hits 1457 1231 -226
Misses 829 829
Partials 2 2
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
|
The container image build workflow finished with status: |
polasudo
reviewed
Sep 15, 2026
polasudo
approved these changes
Sep 15, 2026
jonkoops
force-pushed
the
fix/yarn-install-scripts
branch
from
September 15, 2026 11:18
e6830a2 to
48b5c4d
Compare
jonkoops
force-pushed
the
fix/yarn-install-scripts
branch
from
September 15, 2026 12:09
48b5c4d to
313b785
Compare
better-sqlite3 was bumped to v13, which ships prebuilt binaries for common platforms. We still had enableScripts: true from the Yarn 4.17 upgrade, when v12 needed a local compile. That made Yarn run node-gyp during install even when a prebuild was available, which broke cluster-free E2E on images without a C++ toolchain. Drop enableScripts and the related root workarounds (dependenciesMeta, node-gyp devDependency). Remove the e2e-tests postinstall Playwright hook (removing the need for --mode=skip-build on CI) in favor of documenting an explicit playwright install step. Update stale comments and docs to match, including the e2e README prerequisites anchor after the postinstall heading was removed. Ref: RHDHBUGS-3725 Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
force-pushed
the
fix/yarn-install-scripts
branch
from
September 15, 2026 12:10
313b785 to
474315d
Compare
|
Contributor
|
The container image build workflow finished with status: |
polasudo
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better-sqlite3 v13 ships prebuilt binaries, but our Yarn config still ran install scripts on every dependency. That triggered
node-gypcompiles duringyarn install, which failed in cluster-free E2E on Playwright images that do not havemakeor gcc, even though no compile was needed.#5226 added
enableScripts: truewhen upgrading to Yarn 4.17, because better-sqlite3 v12 still needed a local compile. #5359 bumped better-sqlite3 to v13 with prebuilds, which left that setting forcing unnecessary compiles.This PR turns install scripts off again (Yarn 4’s default), removes the root
dependenciesMetaand thenode-gypdevDependency from #546, drops the e2e-testspostinstallPlaywright hook (removing the need for--mode=skip-buildon CI), and updates docs to describe the manualyarn playwright install chromiumstep and drop the node-gyp toolchain prerequisites. Stale comments in CI and SonarCloud config are trimmed to match.RHDHBUGS-3725