fix(ci): merge the AWS RDS global CA bundle into the RDS trust store [release-1.10] - #5448
gustavolira wants to merge 3 commits into
Conversation
The RDS TLS e2e tests fail with SELF_SIGNED_CERT_IN_CHAIN on all four RDS instances: the Vault copy of rds-db-certificates.pem no longer validates the servers' certificate chains (AWS rotates RDS CAs, and GSM cannot hold the full global bundle — RHDHBUGS-3744 — so the stored copy is a trimmed snapshot that goes stale). Download the official AWS RDS global trust bundle at env-setup time and merge the Vault copy into it, pointing RDS_DB_CERTIFICATES_PATH at the merged file. Both consumers pick it up: the harness pg client (clearDatabase) and the postgres-crt secret mounted into RHDH (configurePostgresCertificate). If the download fails, fall back to the Vault copy alone (current behavior). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/test ? |
|
/test e2e-osd-gcp-helm-nightly |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #5448 +/- ##
=================================================
+ Coverage 41.03% 69.60% +28.57%
=================================================
Files 121 111 -10
Lines 2220 4702 +2482
Branches 539 535 -4
=================================================
+ Hits 911 3273 +2362
- Misses 1304 1428 +124
+ Partials 5 1 -4
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Review follow-up: under errexit a double failure of the cat/cp fallback chain would abort the whole job before the cleanup trap is installed; guard it and keep pointing at the Vault copy in that case. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The container image build workflow finished with status: |
SonarCloud: curl -L could follow a redirect to a non-HTTPS target; restrict both the initial request and any redirect to HTTPS. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
The container image build workflow finished with status: |
|
/test e2e-osd-gcp-helm-nightly /test e2e-ocp-helm-nightly |
|
/test e2e-osd-gcp-helm-nightly |
1 similar comment
|
/test e2e-osd-gcp-helm-nightly |
|
Validation on
The job's only red is one unrelated infra flake: the schema-mode reconfig restart got stuck on a stale |
|
@gustavolira: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Description
The RDS TLS e2e tests in
showcase-runtimefail withself-signed certificate in certificate chainon all four RDS instances (latest .. latest-3) — seen one2e-osd-gcp-helm-nightly,e2e-ocp-helm-nightlyand the operator variants (RHDHBUGS-3411, RHDHBUGS-3691).Root cause
RDS_DB_CERTIFICATES_PATHpoints at the Vault copy of the RDS CA bundle. AWS rotates RDS CAs, and GSM cannot store the full ~170KB global bundle (RHDHBUGS-3744), so the stored copy is a trimmed snapshot that goes stale — the harness pg client (clearDatabase) and RHDH itself (via thepostgres-crtsecret) then reject the servers' chains.Fix
At env-setup time, download the official AWS RDS global trust bundle and merge the Vault copy into it, pointing
RDS_DB_CERTIFICATES_PATHat the merged file. Every current and future RDS CA generation/region validates, custom CAs from Vault are preserved, and if the download fails the behavior falls back to today's (Vault copy only, with a warning).🤖 Generated with Claude Code