Fix InputStreamMonitor.writeNext() busy-spin after closeInputStream() - #765
Merged
robstryker merged 1 commit intoSep 21, 2026
Conversation
Remove !fClosed from the wait loop condition. After closeInputStream() sets fClosed, the condition caused writeNext() to return immediately, making the writeLoop() spin at full CPU until close() sets fThread to null. See: eclipse-platform/eclipse.platform#2882 (review) Fixes redhat-developer#764 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!fClosedfrom thewriteNext()wait loop condition to prevent CPU busy-spin aftercloseInputStream()is calledFixes #764
Test plan
closeInputStream(), the monitor thread parks inwait()instead of spinning🤖 Generated with Claude Code