Repository navigation
Conversation
Move using directives onto @import.path and the CSharp normaliser, retaining targets, sites, order, flags and existing alias behaviour. Remove the redundant extractor; leave bindings to slice 2b. Pin the shared-capture depth disclosure/cacheability exception, add real-input mutation controls, and advance parser identity to 186 with its quality mirror. No shared binding API changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C# using directives currently use a separate AST walk. This moves them onto the shared import.path capture with a minimal CSharp normaliser, and removes csharpUsingTarget and its directiveTargetOf branch.
Existing behaviour is preserved for written targets, directive sites and ordering, duplicate directives, static/global forms, dependency edges, and bindings. The existing using X = … alias gap remains pinned by a known-gap test; alias migration stays in slice 2b after the maintainer-owned shared binds channel. No shared binding API is added here.
One disclosure/cache behaviour change matches the precedent from Python #382: at container depths 257/258, import-free deep containers (including a top-level using followed by a deep empty container) no longer mark the file extract-partial and may reuse the whole-file cache. A real using beyond the bound is still cut, disclosed as partial, and not captured. Dependency output remains byte-identical across the boundary fixtures.
Parser identity moves from 196 to 198 (rich 199); cache record format 36 and quality scheme 22 are unchanged.
Validation against main 939dbb6, head 193d69b:
Part of Shared import-capture vocabulary instead of ~21 per-language import extractors #358 — C# slice 1a.
Summary by CodeRabbit
usingdirectives are now recognized as imports, improving dependency reporting while preserving directive locations and ordering.using X = Foo.Barare not yet reported under the alias name.