Skip to content

Fix Node.js 20 is deprecated warning - #177

Open
vishalvvr wants to merge 1 commit into
redhat-performance:mainfrom
vishalvvr:node-dep-warning-fix
Open

vishalvvr wants to merge 1 commit into
redhat-performance:mainfrom
vishalvvr:node-dep-warning-fix

Conversation

@vishalvvr

@vishalvvr vishalvvr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Warning:
Node.js 20 is deprecated.
The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v3.[2]

Fix:
Use checkout@v4 instead of v3 .[1]

[1] https://github.com/orgs/community/discussions/190988
[2] https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners

Warning:
Node.js 20 is deprecated.
The following actions target Node.js 20 but are being forced to
run on Node.js 24: actions/checkout@v3.[2]

Fix:
Use checkout@v4 instead of @V3.[1]

[1] https://github.com/orgs/community/discussions/190988
[2] https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners
@vishalvvr vishalvvr added the fix-warnings Fix warnings label Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the GitHub Actions lint workflow to use actions/checkout@v4 instead of actions/checkout@v3. No other configuration values or workflow behavior are changed.

Changes

CI Linter Workflow Update

Layer / File(s) Summary
Checkout action version bump
.github/workflows/linter.yml
The checkout action used in the lint workflow is upgraded from v3 to v4; Super-Linter validation toggle settings remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: N/A

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change: updating checkout to address the Node.js 20 deprecation warning.
Description check ✅ Passed The description accurately explains the warning and the checkout v4 fix reflected in the diff.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/linter.yml (1)

11-14: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Consider disabling credential persistence on checkout.

actions/checkout persists the GITHUB_TOKEN in the local git config by default, which subsequent steps (e.g., Super-Linter) can access unnecessarily. Not introduced by this PR, but worth hardening while touching this step.

🔒 Suggested fix
     - uses: actions/checkout@v4
       with:
         ref: ${{ github.event.pull_request.head.sha }}
         fetch-depth: 0
+        persist-credentials: false
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/linter.yml around lines 11 - 14, The checkout step
currently leaves the GITHUB_TOKEN persisted in git config, which later steps
like Super-Linter can access unnecessarily. Update the actions/checkout usage in
the linter workflow to disable credential persistence by setting the checkout
action’s credential persistence option to false while keeping the existing ref
and fetch-depth settings intact.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/linter.yml:
- Around line 11-14: The checkout step currently leaves the GITHUB_TOKEN
persisted in git config, which later steps like Super-Linter can access
unnecessarily. Update the actions/checkout usage in the linter workflow to
disable credential persistence by setting the checkout action’s credential
persistence option to false while keeping the existing ref and fetch-depth
settings intact.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 668ec2a7-9af7-4f51-be6b-2044fa783ea4

📥 Commits

Reviewing files that changed from the base of the PR and between 29bdf09 and bcd4fc9.

📒 Files selected for processing (1)
  • .github/workflows/linter.yml

@jhutar

jhutar commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hello @vishalvvr . Please fix the conflict here and we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix-warnings Fix warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants