Scale the ACP subprocess waits for the slow platform too - #50
Merged
Merged
Conversation
A third Windows shard failed, and this one was not a spawn timeout: `stdin EOF exits cleanly` gave a subprocess five seconds to exit and failed at 6.5s with a bare `TimeoutError`. Windows process teardown is slower, and five seconds was tight enough to flake. Every wait in the ACP test client is on a subprocess round trip, so all three bounds now go through the same scaler as the harness: the request wait, the notification wait's default, and the explicit values callers pass to it. This is the third place a fixed millisecond figure met a slower platform, after the spawn timeout and the ready timeout. The pattern is the point -- a bound written as a literal beside a subprocess is a bound that will eventually be too small on somebody's machine, and `slowPlatform` is where that correction belongs rather than in each number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third in the sequence after #47 and #49, and a different failure from either.
stdin EOF exits cleanlygives a subprocess five seconds to exit and failed at 6.5s with a bareTimeoutError— not a spawn timeout, so neither earlier fix reached it. Windows process teardown is slower and five seconds was tight enough to flake.Every wait in the ACP test client is on a subprocess round trip, so all three bounds now go through the same scaler as the harness: the request wait, the notification wait's default, and the explicit values callers pass it.
The pattern is the finding
This is the third place a fixed millisecond figure met a slower platform — after the spawn timeout and the ready timeout. A bound written as a literal beside a subprocess is one that will eventually be too small on somebody's machine, and
slowPlatformis where that correction belongs rather than in each number.Still worth repeating from #47: these are mitigations. What actually changed diagnostically is that a subprocess timeout now reports what the child printed, where before both streams were discarded at two separate layers.
Gates