Fix mixed OrderedFloat equality for NaN values - #185
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
Collaborator
|
I'm slightly concerned about the silent behavior change here, though I can't think of a likely scenario where it causes a problem. Is this a high priority fix for anyone? If not, perhaps it should wait a while to see if we have a chance to bundle it into a new major version. |
Author
|
Waiting for a major release makes sense. This PR addresses an equality consistency issue. I do not have evidence of urgent downstream impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OrderedFloat<T> == Tused primitive equality, so NaN values compared unequal despite the wrapper equality contract.Change
Reuse
OrderedFloat<T>equality for mixed equality.Add f32 and f64 regression tests for NaN payloads, finite values, infinities, signed zero, and inequality.
Verification
cargo fmt --checkcargo testcargo test --no-default-featurescargo test --no-default-features --features libmcargo test --features std,schemarscargo test --features rand,randtestcargo test --features arbitrary,bytemuck,rand,randtest,serde,schemars,proptest,rkyv,rkyv_ck,speedy,facetcargo clippy --tests --features arbitrary,bytemuck,rand,randtest,serde,schemars,proptest,rkyv,rkyv_ck,speedy,facetAll checks pass with Rust 1.94.1.
This change does not add mixed
PartialOrdor reverse-comparison APIs.Related to #143. This addresses the equality discrepancy only.
The Rust 1.90 CI job has not been run locally.