Also disable Style/MethodCallWithoutArgsParentheses - #5
Merged
reese merged 1 commit intoSep 9, 2026
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rubyfmtappends()to a receiver-qualified no-arg call when a local variable shares the method's name, so that the call stays a call rather than resolving to the variable (playground).Style/MethodCallWithoutArgsParenthesesremoves exactly those parens, so the two autocorrects revert each other indefinitely.Reported in #3, where you noted it makes sense to disable. I hit it independently on a Rails app:
policy_violations = ... self.policy_violations(), where the local really does shadow the method. Verified by autocorrecting that one cop against arubyfmt-clean tree and re-runningrubyfmt --check, which then fails.Left
Style/IfUnlessModifierfrom that issue alone — it sounded like it's headed forfull.yml, and @tsukkee offered to pick it up.