Repository navigation
Accessibility Audit 1.2.0: crawl scope, stop and resume, results pipeline, and detection fixes - #4
Merged
Conversation
…line, and detection fixes Fixes from a full audit of a large WordPress multisite with many subsites, where a third of the time went to addresses that are not pages of the site. - Scope: exact hosts in permitted_domains (*.example.com for subdomains), host patterns in the settings, page keys with the host for other hosts, and checks after the first load: redirects off site or to a skipped path, files, broken links (one error page tested), and bot challenges are not tested and do not count in the coverage. - Discovery: sitemaps to 4 levels, the WordPress API of each subsite, robots.txt as RFC 9309, and the frontier by priority and by section. - Ctrl+C stops an audit with its results; --resume continues a run that a stop or a crash ended. - refresh counts the pages again, keeps answers by the hashes of all the items of a question, and tasks keep to the budgets (--limit). - Detection: same-name-different-target (2.4.4), a pixel check for covered text, image-text-contrast (1.4.3), the focused measure of a clipped skip link, and no false controls from analytics scripts or library containers. - The command is refact-a11y (a11y stays as an alias). The docs never suggest npx, and give the npm 12 steps. - New tests: scope, discovery, stop, refresh, rules, docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version 1.2.0. Fixes from a full audit of a large WordPress multisite with many subsites. In that audit, a third of the time went to addresses that are not pages of the site. A person had to remove 1,327 page records by hand.
The list had 23 items. Each item has a fix and a test, and each new test fails on 1.1.1 for its item. The details are in
CHANGELOG.md.The scope of the crawl (items 1 to 9)
permitted_domainsnames exact hosts.*.example.compermits subdomains. Thewwwhost is the site host.The discovery (items 10 to 12, 14)
A stop and a resume (item 13)
refact-a11y audit --resumecontinues the run, also after a crash.The results pipeline (items 15 to 17)
refreshcounts the pages again.taskskeeps to the budgets, and--limitreplaces them.The detection (items 18 to 21)
same-name-different-target(2.4.4).image-text-contrast(1.4.3): the letters of a transparent image of text against the page under them.The install (items 22, 23)
refact-a11y. The old namea11ystill works in a project that has the package.npx a11y: an unrelated package on the npm registry has that name.Test plan
npm test, with six new test files:scope,discovery,stop,refresh,rules,docs.