Repository navigation
Accessibility Audit 1.3.0: crawl order, budgets, stable IDs, states, and loading - #5
Merged
Merged
Conversation
…and loading
Fixes from the second full audit of a large WordPress multisite, with 1.2.0,
where the sitemaps filled the time budget and most planned states did not
count with no reason in the log.
- Crawl order and budgets: the links get 1 of each 4 places after the
settings; a quick check with no browser classifies the addresses that a
budget left; pages_not_opened is apart from pages_found; max_pages counts
opened pages only; slash copies of opened pages go; address groups choose
from the whole list before the crawl (order sample, newest, or first).
- Stable identity: the random parts of ids and names are left out of the
issue identity, the selectors, and the question hash. An older axe-core
issue moves to its new ID with its status and solution ("rule changed").
- Results: widths_not_loaded for a page that loaded at some widths only,
found_in for out-of-scope addresses from a sitemap or an API, and one
page-not-linked question for each section with the reasons.
- Loading and detection: the document first, then load_wait_seconds for
the load event; the image contrast check right after the load and again
for later slides; state controls found before the tests change the page
and found again by identity, then by tag and name; a dialog that is open
before a click is not the dialog of the state.
- Log: a reason for each state not applied (states_planned and
states_not_applied in the summary) and the count from each source.
- README: the npm 12 upgrade steps (uninstall, then install the new tag).
- Tests: budget and identity, in npm test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version 1.3.0. Fixes from the second full audit of the large WordPress multisite, with 1.2.0. The list had 12 items. Each item has a fix and a test, and each check of an item fails on 1.2.0. The details are in
CHANGELOG.md.The crawl order and the budgets (items 1, 2, 3)
pages_not_opened, not inpages_found.max_pagescounts the opened pages only.orderissample(the default),newest, orfirst.The results and the IDs (items 4 to 7)
widths_not_loaded.found_in.page-not-linkedgives one question for each section, with what the crawl did not open there and why.The loading and the detection (items 8, 9)
crawl.load_wait_seconds(20) for its load event. Then the engine tests the page as it is, and the report names it.The states and the log (items 10, 11)
role="dialog", is not the dialog of the state.summary.jsongivesstates_plannedandstates_not_applied.The install (item 12)
EALLOWGIT.Test plan
npm test, with two new test files:budgetandidentity.