Skip to content

Accessibility Audit 1.3.1: issue statuses, network retry, and state counts - #6

Merged
HosseinKarami merged 2 commits into
mainfrom
fix/1.3.1-statuses-and-retry
Nov 4, 2026
Merged

HosseinKarami merged 2 commits into
mainfrom
fix/1.3.1-statuses-and-retry

Conversation

@HosseinKarami

Copy link
Copy Markdown
Member

Summary

Version 1.3.1. Fixes from the third full audit of the large WordPress multisite, with 1.3.0. The audit compared the site with results of 1.1.1, and it marked 10 issues "fixed", but their elements still failed. The details are in CHANGELOG.md.

The statuses

  • Several issue IDs of an older version can give one new ID, for example a select whose random name was different on each page. Now each old ID is resolved with the reason "rule changed". Before, only the first one was "rule changed", and the others were "fixed" (src/issues.ts).
  • Some tests run on the sample pages only, for example the listener test. An issue of such a test is "not checked" when its page is not in the sample. Before, the engine decided by the criterion: axe-core tests 4.1.2 on each page, so an issue of the listener test on a page out of the sample was resolved.
  • A refresh corrects the statuses that 1.3.0 gave for these two reasons. The next audit corrects a false "fixed" too. On a copy of the multisite results, a refresh changed exactly the 14 records that were wrong: 10 to "rule changed", 4 to "not checked". No other record changed.

The page loads

  • A load that a short network fault stops, for example net::ERR_NETWORK_CHANGED, gets one more try after 5 seconds. Before, only a time-out got a second try.

The counts

  • The states with the cookie banner open and the states of the dry submit have their own counts in summary.json and in the report. Before, states_tested was larger than states_planned, and nothing told why.

Not changed

  • The contrast check of the letters of an image of text runs at the first width only, as in 1.2.0. This is a design choice. The README now gives it as a limit.

Test plan

  • npm test, with a new test file, statuses.
  • The new test on the 1.3.0 code: each of its checks of a fix fails there (9 failures).
  • A refresh with this branch on a copy of the multisite results: the 14 wrong statuses are corrected, and nothing else changes.
  • A second full audit of the multisite with 1.3.1, to see the ID stability, the quick check, and the budgets.

…ounts

Fixes from the third full audit of a large WordPress multisite, with 1.3.0,
which compared the site with results of 1.1.1 and marked 10 issues "fixed"
although their elements still failed.

- Merged IDs: when several old IDs give one new ID, each old ID is
  resolved "rule changed", not only the first. The new issue takes the
  origin, source, specific solution, and decision that it lacks.
- Sample rules: an issue of the listener, focus, or operate test is
  checked against the sample pages, by its rule, not by its criterion.
  An issue on a page out of the sample is "not checked".
- Corrections: a refresh corrects both false statuses of 1.3.0, and the
  next audit corrects a false "fixed". The run of a resolution stays.
- Loading: a load that a short network fault stops (for example
  net::ERR_NETWORK_CHANGED) gets one more try after 5 seconds.
- Counts: banner_states_tested and form_states_tested in the summary and
  the report, so states_tested and states_planned agree.
- README: the image contrast check runs at the first width only.
- Tests: statuses, in npm test. Each check of a fix fails on 1.3.0.
@HosseinKarami
HosseinKarami merged commit bc0eece into main Nov 4, 2026
1 check passed
@HosseinKarami
HosseinKarami deleted the fix/1.3.1-statuses-and-retry branch November 4, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant