Repository navigation
Accessibility Audit 1.3.1: issue statuses, network retry, and state counts - #6
Merged
Merged
Conversation
…ounts Fixes from the third full audit of a large WordPress multisite, with 1.3.0, which compared the site with results of 1.1.1 and marked 10 issues "fixed" although their elements still failed. - Merged IDs: when several old IDs give one new ID, each old ID is resolved "rule changed", not only the first. The new issue takes the origin, source, specific solution, and decision that it lacks. - Sample rules: an issue of the listener, focus, or operate test is checked against the sample pages, by its rule, not by its criterion. An issue on a page out of the sample is "not checked". - Corrections: a refresh corrects both false statuses of 1.3.0, and the next audit corrects a false "fixed". The run of a resolution stays. - Loading: a load that a short network fault stops (for example net::ERR_NETWORK_CHANGED) gets one more try after 5 seconds. - Counts: banner_states_tested and form_states_tested in the summary and the report, so states_tested and states_planned agree. - README: the image contrast check runs at the first width only. - Tests: statuses, in npm test. Each check of a fix fails on 1.3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version 1.3.1. Fixes from the third full audit of the large WordPress multisite, with 1.3.0. The audit compared the site with results of 1.1.1, and it marked 10 issues "fixed", but their elements still failed. The details are in
CHANGELOG.md.The statuses
src/issues.ts).The page loads
net::ERR_NETWORK_CHANGED, gets one more try after 5 seconds. Before, only a time-out got a second try.The counts
summary.jsonand in the report. Before,states_testedwas larger thanstates_planned, and nothing told why.Not changed
Test plan
npm test, with a new test file,statuses.