Repository navigation
Accessibility Audit 1.3.2: results across runs, refresh, and unstyled renders - #7
Merged
Merged
Conversation
… renders
Fixes from the fourth full audit of a large WordPress multisite, with 1.3.1
and a short time budget, which lost 17 AI answers, and whose refresh
changed many files with no new data.
- Questions: a question whose pages the run did not test stays with its
answers as not_checked, also after a short check. Review tasks, the
counts, and the report leave these out.
- Sample: the pages of open issues of sample-only tests open first and
join the sample ("open issue"), so each audit checks those issues.
- Rule changed: an own rule changes only when its detection version
(src/own/versions.ts) is newer than the engine that found the issue.
- Identity: lazy-load classes (lazyloaded, ls-is-cached, ...) are left out
of items and question hashes; old IDs move with status and answers.
- Refresh: keeps replaces, the example of each question, and every part
of the report (runs/<run>/report-data.json; title, sample reason,
load_incomplete, styles_missing in pages.jsonl).
- Loading: a page whose stylesheet request failed loads once more; a
stylesheet that stays missing is reported.
- Report: the pages that a budget left, by source and section; the
Resolved column counts this run only.
- Tests: across-runs, in npm test. Each check of a fix fails on 1.3.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version 1.3.2. Fixes from the fourth full audit of the large WordPress multisite, with 1.3.1 and a short time budget. The run lost 17 AI answers, and a refresh changed many files with no new data. The list had 10 items. The details are in
CHANGELOG.md.The results from run to run
"not_checked": true. Before, the run deleted it. Each short check (refact-a11y check) deleted the questions of all the pages that it did not test. The report counts these questions apart, and the review tasks skip them.src/own/versions.ts). Before, each release made every such issue "rule changed".lazyloaded,ls-is-cached, and others) are not part of the identity or the question hash. The old IDs move to the new ones with their status, answers, and solution.The refresh
replaces, the example of each question, and every part of the report. The audit writes the crawl parts of the report toruns/<run>/report-data.json, andpages.jsonlkeeps the title, the reason of the sample,load_incomplete, andstyles_missing.The page loads
The report
Test plan
npm test, with a new test file,across-runs(19 checks).statusesnow checks the "not checked" rule with the status code, because an audit adds such a page to the sample.