Repository navigation
example: regenerate lockfiles (drop nested react-native 0.86.3) - #96
Merged
Merged
Conversation
The example lockfile carried a nested react-native@0.86.3 under node_modules/react-native (pulled in via @react-native/virtualized-lists), which made RN 0.79's hermes-engine podspec resolve the wrong version and try to build Hermes from source. Regenerated from scratch: single react-native 0.79.7, hermes 0.79.7, RefinerSDK 2.0.0 from the public repo. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Regenerates
example/package-lock.jsonfrom scratch and commits the resultingexample/ios/Podfile.lock. The previous lockfile nestedreact-native@0.86.3undernode_modules/react-native(via@react-native/virtualized-lists), so RN 0.79.7'shermes-engine.podspecresolved the wrong React Native version, found no Hermes tarball and tried to build Hermes from source (cmakemissing). Now: onereact-native 0.79.7,hermes-engine 0.79.7,RefinerSDK 2.0.0from the public repo.How to test it
cd example && npm ci && cd ios && pod installcompletes without building Hermes;Podfile.locklistsRefinerSDK (2.0.0)andhermes-engine (0.79.7).Acceptance criteria
react-nativein the example lockfile;pod installsucceeds.Link to ticket
https://trello.com/c/ywKiYIhs
🤖 Generated with Claude Code