Repository navigation
build(perf): Cut full rebuild time and the ARM64 CI jobs - #184
Merged
Merged
Conversation
…tbVorbisWrapper.cpp with the PCH
…files are linked, and make MSB8027 an error
…ps1 for extra MSBuild properties
…ests one vstest per core
relmer
marked this pull request as ready for review
November 10, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, opened to measure CI. Build time roughly doubled when 033 merged: a Debug x64 rebuild went from 42 s to 78 s on a 32-core machine, and the CI run from about 17.5 to 31 minutes.
Changes
Dxui/Pch.hintoDxui/Window/DxuiWinRt.h, which onlyDxuiPopupHost.cppincludes. They take about 4 s to parse. Dxui headers includePch.handDxui.his in three other precompiled headers, so that cost was paid four times.CheckStyle.ps1andcopilot-instructions.mdhave the exception to the angle-bracket rule.CassoEmuCoreno longer referencesCassoCoreandDxui; a static library does not link them, so the references only imposed build order.CassoCliandScenarioTestsreferenceDxuidirectly.StbVorbisWrapper.cppwith the PCH. It was a separate one-file compile step that parsedPch.hagain.MultiProcFXC).UnitTest/CassoLink/BootDiskTests.cppand its class toCassoLinkBootDiskTests. Two files with that name compiled to one.obj, so its three tests were never linked or run. MSB8027 is now an error.scripts/ProfileBuild.ps1, plus-BinaryLogand-Propertyoptions forBuild.ps1.Measured locally (Debug x64 rebuild, 32 cores, nothing else building)
Verification
BootDiskTestsclasses pass after them (7 of 7).UnitTest.dll.Open question
The parallel-library, shader and link changes mostly use idle cores, which a 4-core runner does not have. How much of the local gain applies on CI is unknown until this PR's run finishes.