fix(gomod): pseudo-version digest updates produce no change when module is absent from go proxy#44477
Open
Maydaer wants to merge 1 commit into
Open
fix(gomod): pseudo-version digest updates produce no change when module is absent from go proxy#44477Maydaer wants to merge 1 commit into
Maydaer wants to merge 1 commit into
Conversation
is absent from go proxy
RahulGautamSingh
suggested changes
Jul 10, 2026
| packageFile: 'go.mod', | ||
| upgrade, | ||
| }); | ||
| // Should fall back to bare hash since newValue === currentValue |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Should fall back to bare hash since newValue === currentValue |
same as test name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Since Renovate version 43.167.0 (which includes PR #41588), digest updates for Go modules with pseudo-versions no longer produce file changes, if the repository is unavailable in the goproxy (for example repos on github enterprise instances, private repositories, etc).
The update process detects a newer commit, but only for newDigest.
The lookup for the new commit on proxy.golang.org fails, which causes upgrade.newValue in gomod.update to be equal to the current (old) value.
However, since current value is a pseudo-version, the version starts with v0.0.0-and gomod.update goes into the new code path
added by the above PR, but since newVersion is the old version, no file changes occur.
This PR ensures the old behavior is triggered, if newValue and oldValue are identical, which handles the case where goproxy is unavailable.
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
I used claude opus for the writing the test and the code change, but did some manual edits.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: