Repository navigation
fix: accept Magpie output token compatibility hints - #15
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magpie sends
max_output_tokensto the public Responses endpoint, which currently rejects the request with HTTP 422 before contacting Codex. Accept positive unsigned 64-bit integers or null so Claude Code can use this gateway through Magpie without a separate adapter. Reject zero and invalid types, and retain strict rejection of other unknown fields.Codex has no corresponding output-token limit parameter. This value is a documented compatibility hint: it is neither forwarded nor enforced, and callers must not rely on it for a hard generation limit.
Adds streaming and nonstreaming tool-call regression coverage, updates the official SDK parameter contract and audit, and documents direct Magpie configuration.
Validation: