Repository navigation
Conversation
…recedence Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VD8gaUA7K5gseR3E5X8cBA
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VD8gaUA7K5gseR3E5X8cBA
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2 of the Phase −1 bug-fix stack.
Switch/Switch.tsx): addedrole="switch"to the native checkbox.aria-checkedisn't set, because the nativecheckedstate already exposes it. oxlint'srole-has-required-aria-propsdoesn't know that, so there's a scoped disable comment with the reason.onChangewithoutname(HiddenInput/HiddenInput.tsx): removed theif (!name) returnguard. Checkbox, Radio and HiddenInput now callonChangewhen nonameis passed.namecomes through as""to match theChangeHandlertype.disabledprecedence (HiddenInput/HiddenInput.tsx):??became||, matching Checkbox and Radio.FormControl disabled={false}no longer re-enables a disabled group or input.Tests:
Switch.stories.tsxnow queriesgetByRole("switch").HiddenInput.stories.tsxstories:test: onChange without nameandtest: disabled precedence.Related Issue
Phase −1 of the headless-extraction plan.
Screenshots / Recordings
No visual changes.
Notes for Reviewers
fix/form-control-a11y).pnpm lintpasses.pnpm test:browserhas 609 passing and 1 failing,Image > onLoad, which fails onmaintoo in this sandbox because it has no network access.Generated by Claude Code