Repository navigation
Conversation
…essible name Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VD8gaUA7K5gseR3E5X8cBA
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 8, the last PR in the Phase −1 bug-fix stack.
Expandable/Expandable.tsx):onNextFrame) whether awidth/heightCSS transition is running. If not, it settles immediately: clears the inline size, setshiddenwhen closed, and callsonAfterClose.pendingTransitionRefstops the fallback from settling twice whentransitionenddoes fire, or afteractivehas changed again.Tabs/TabsList.tsx): the same fallback for the selection indicator. When the status isanimatedand the selector has no running animations, the status goes back toidle. It only updates while the status is stillanimated.Divider/Divider.tsx): string children are now used asaria-labelon therole="separator"element. Separator children are presentational, so the label wasn't announced. Anaria-labelpassed inattributestakes precedence.Tests (each fails on the base branch and passes here):
Expandable.stories.tsx:test: settles without size transitionTabs.stories.tsx:test: selector settles without transitionDivider.stories.tsx:test: labelRelated Issue
Phase −1 of the headless-extraction plan.
Screenshots / Recordings
No visual changes with the default styles.
Notes for Reviewers
fix/toast).data-rs-no-transitionon<html>after it runs. In a full-file run, later stories therefore run with transitions disabled.enableTransitions()first so they cover the animated path.getAnimations(). That way it also handles custom styles that keep transitions on other properties.pnpm lintandtscpass.pnpm test:unithas 181 passing.pnpm test:browserhas 628 passing and 1 failing,Image > onLoad, which also fails onmainin this sandbox because it has no network access.Generated by Claude Code