Bumping to Rails 8 - #44
Merged
Merged
Conversation
naterod-reverb
requested review from
a team,
Copilot,
jonhoman,
matteodartez,
mcostanza,
reubenbrown,
teresabocchini and
wenn
August 4, 2026 16:25
There was a problem hiding this comment.
Pull request overview
Updates Attachinary’s dependency set to be compatible with Rails 8 (and aligned Ruby/runtime tooling) so downstream “core” can move to Rails 8 while continuing to build and publish this gem.
Changes:
- Bump Rails (and related gems) to Rails 8.x via updated lockfile resolution.
- Remove git-pinned dependencies (mongoid, factory_bot_rails) in favor of released gem versions.
- Update Ruby to 3.2.7 and bump the gem version.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/attachinary/version.rb | Bumps Attachinary gem version to 1.3.0.18. |
| Gemfile.lock | Resolves dependencies against Rails 8.0.5.1; replaces prior git sources with released gems. |
| Gemfile | Switches mongoid/factory_bot_rails from git pins to released version constraints. |
| attachinary.gemspec | Broadens Rails dependency range to allow Rails 8; updates sqlite3 dev dependency constraint. |
| .ruby-version | Updates repo Ruby version to 3.2.7. |
| .github/workflows/test.yaml | Updates CI Ruby version to 3.2.7. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
+31
| # 6.5.1 carries the PR that PLAT-2226's git ref tracked; released gem needs only railties >= 6.1.0 | ||
| gem 'factory_bot_rails', '>= 6.5.1' |
Comment on lines
+27
to
+30
| s.add_dependency 'rails', '>= 7.2.1', '< 8.1' | ||
| s.add_dependency 'cloudinary' | ||
|
|
||
| s.add_development_dependency 'sqlite3' | ||
| s.add_development_dependency 'sqlite3', '~> 2.1' |
reubenbrown
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to bump this to Rails 8 to support bumping core to Rails 8.
Soundcheck shows that this builds into a valid Docker image (the beta Rails 8 branch pulls from this working branch):
