Repository navigation
Conversation
A user-implemented mapping referenced with Use received the default value for its [MappingTargetOriginalValue] parameter. The member mapping builder looked for the parameter on the wrapper that UseNamedMappingBuilder creates, not on the referenced mapping. CompositeMapping now holds the referenced mapping and its optional input and output conversions. Only the referenced mapping receives the target value. The target value is passed only when the target member is readable and its type converts implicitly to the parameter type. Otherwise the parameter receives its default value, and Mapperly reports RMG102 for a member that is not readable and RMG101 for a type that does not fit. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A user-implemented mapping referenced with
Usereceiveddefaultfor its[MappingTargetOriginalValue]parameter, even when the target member already had a value. The same method picked by type received the member value.UseNamedMappingBuilderwraps the referenced mapping, and the member mapping builder looked for the parameter on the wrapper, not on the method inside it.Before:
After:
What changed:
CompositeMappingnow holds the referenced mapping and its optional input and output conversions, so the member mapping builder can find the referenced mapping. Only the referenced mapping receives the target value. The conversions do not, as before.default, and Mapperly reports a new warning:RMG102for a member that is not readable,RMG101for a type that does not fit.InvalidOperationExceptionin the generator, and a type that does not fit produced code that does not compile.There is no issue for this bug yet.
Checklist