Conversation
luhenry
added a commit
that referenced
this pull request
Sep 8, 2026
pylance is lance's own Python binding (python/ subdir of lancedb/lance, maturin/PyO3-based). Ships one cp310-abi3 wheel per upstream's own CI matrix, built here on cp312. lance-linalg's f32/f64/i32 SIMD types compile only for x86_64/aarch64/loongarch64 upstream (unlike u8, which already has a portable fallback); patches/pylance/11.0.0/0001*.patch adds the same shape of fallback, verified against an isolated copy of the module with cargo check for riscv64gc-unknown-linux-gnu plus aarch64/x86_64 regressions.
The test asserts LANCE_LOG_FILE under an unwritable parent directory never gets created, expecting a permission failure to fall back to stderr logging. The cibuildwheel test phase runs as root in the manylinux container, and root can create arbitrary paths, so the assertion never held here (gotcha 39/83: this is a root-vs-container quirk, not riscv64-specific).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylance11.0.0Compiles Lance's Rust core (arrow, datafusion, lance-index, lance-namespace) into a pyo3 abi3 extension via maturin - pylance is lance's own Python binding, living under
python/in the same repo. Upstream publishes no riscv64 wheel.Mirrors upstream's
pypi-publish.yml.Differs from upstream
build-lancedb.ymlfp16kernelsfeature - no riscv64 equivalentMatrix: cp312 only - pyo3 carries
abi3-py310unconditionally, so one build covers every interpreter (asbuild-lancedb.ymldoes)Testing
make test(no marker filtering), with pytest-xdist's auto workersml_dtypeshas no riscv64 wheel and builds from its (pure C++) sdist insteadLicense: OK
Patches
0001-lance-linalg-add-a-portable-riscv64-simd-fallback.patch- To upstream. Adds a portable fallback for SIMD types that only compile on x86_64/aarch64/loongarch64; reproduces on riscv64 only.Built on cp312; TBD passed, TBD skipped.