Skip to content

fix(rivetkit-napi): remove stale HttpRequestBodyStream test after envoy v6 revert - #5604

Closed
abcxff wants to merge 1 commit into
mainfrom
stack/fix-rivetkit-napi-remove-stale-httprequestbodystream-test-after-envoy-v6-revert-rlmrkmtk
Closed

fix(rivetkit-napi): remove stale HttpRequestBodyStream test after envoy v6 revert#5604
abcxff wants to merge 1 commit into
mainfrom
stack/fix-rivetkit-napi-remove-stale-httprequestbodystream-test-after-envoy-v6-revert-rlmrkmtk

Conversation

@abcxff

@abcxff abcxff commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Stack for rivet-dev/actors

Get stack: forklift get 5604
Push local edits: forklift submit
Merge when ready: forklift merge 5604

change rlmrkmtk

@railway-app

railway-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

🚅 Deployed to the actors-pr-5604 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Aug 31, 2026 at 3:47 pm
website ❌ Build Failed (View Logs) Web Aug 31, 2026 at 1:40 am
kitchen-sink 😴 Sleeping (View Logs) Web Aug 27, 2026 at 10:10 pm
frontend-inspector 😴 Sleeping (View Logs) Web Aug 27, 2026 at 9:42 pm
ladle ✅ Success (View Logs) Web Aug 25, 2026 at 7:30 pm
mcp-hub ✅ Success (View Logs) Web Aug 25, 2026 at 7:28 pm

@claude

claude Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review

Small, correct cleanup. The removed test (cancelling_http_request_body_drops_core_receiver) and its imports (HttpRequestBodyStream, CoreHttpRequestBodyStream from rivetkit_core, tokio::sync::{mpsc, watch}) referenced types that no longer exist in the codebase — I confirmed HttpRequestBodyStream has zero remaining references anywhere in the repo (consistent with the "envoy v6 revert" mentioned in the commit message). Leaving this test in place would have failed to compile, so removing it is the right call rather than a coverage regression to work around.

Code quality: Clean diff, no dead imports left behind. The remaining tests in the file (parse_bridge_rivet_error_uses_dynamic_error_kind, napi_bridge_payload_promotes_known_core_error_status, parse_bridge_rivet_error_warns_for_malformed_payload) still compile fine and their imports (BRIDGE_RIVET_ERROR_PREFIX, parse_bridge_rivet_error) are untouched.

Bugs/security/perf: None applicable — this is a pure test deletion with no production code changes.

Test coverage: No net loss in meaningful coverage since the feature under test (HttpRequestBodyStream cancellation) was reverted along with envoy v6. If request-body cancellation is reintroduced later, it'll need new coverage at that point, but there's nothing to test today.

Nothing blocking — looks good to merge.

@abcxff
abcxff force-pushed the stack/fix-rivetkit-napi-remove-stale-httprequestbodystream-test-after-envoy-v6-revert-rlmrkmtk branch from 4419d64 to 133b437 Compare August 31, 2026 01:40
@railway-app
railway-app Bot temporarily deployed to rivet-frontend / actors-pr-5604 August 31, 2026 01:40 Destroyed
@abcxff abcxff closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant