fix(rivetkit): omit native engine path for wasm runtime - #5626
Open
NathanFlurry wants to merge 1 commit into
Open
fix(rivetkit): omit native engine path for wasm runtime#5626NathanFlurry wants to merge 1 commit into
NathanFlurry wants to merge 1 commit into
Conversation
NathanFlurry
commented
Aug 31, 2026
Member
- Pass the npm Engine binary path only to the native runtime.
- Preserve native local-Engine startup while allowing configured WASM registries to initialize.
|
🚅 Deployed to the actors-pr-5626 environment in rivet-frontend
|
Contributor
Code ReviewReviewed this PR (fix(rivetkit): omit native engine path for wasm runtime) against the repo conventions in CLAUDE.md. Summary: Small, well-scoped fix that gates native engine-binary-path resolution behind runtimeKind === "napi" in rivetkit-typescript/packages/rivetkit/src/registry/native.ts, so WASM registries no longer get (and do not need) a native binary path. Findings: None survived review. Verification performed:
Test coverage looks appropriate for the change (registry-constructor test updated to assert the wasm path leaves engineBinaryPath undefined while native still resolves it). No security, performance, or style concerns found. Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.