Repository navigation
delegate font resolution in ro_gt_theme/ro_dt_theme to ROvis.utils - #8
Merged
Merged
Conversation
Sjonnie404
approved these changes
Sep 15, 2026
Sjonnie404
left a comment
Sjonnie404
left a comment
Contributor
There was a problem hiding this comment.
LGTM
tests:
`══ Results ═════════════════════════════════════════════════════
Duration: 1.8 s
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 10 ]`
Check:
`── R CMD check results ────────────────── ROvis.table 0.1.0 ────
Duration: 1m 0.9s
❯ checking top-level files ... NOTE
Non-standard file/directory found at top level:
‘CONTRIBUTORS.md’
0 errors ✔ | 0 warnings ✔ | 1 note ✖
R CMD check succeeded`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both themes hardcoded their own font fallback instead of using
ro_check_if_font_available()ro_gt_theme keeps its ROfont opt-in gate: it always resolves through the RO font chain, downgrades to
Verdana only if ROfont=FALSE and RO happens to be installed, and stays quiet about it unless ROfont=TRUE.
Also drops the now-unused systemfonts dependency from both the package imports and DESCRIPTION, and adds a
test file for ro_dt_theme (none existed) plus fallback tests for ro_gt_theme.
Closes #9
Note wrong branch name (15 instead of 9, oopsie)