Repository navigation
Use linuxdeploy's built-in AppImage plugin from a fixed release - #175
Merged
Merged
Conversation
The standalone linuxdeploy-plugin-appimage is only published as `continuous`, which upstream rebuilds on the 1st of every month, so the pinned hash broke every Linux build each month until it was re-pinned. Download the linuxdeploy copy Tauri pins (tauri-apps/binary-releases `linuxdeploy-07333c6`, built by linuxdeploy's CI from commit 07333c6), verify its SHA-256, unpack it and run the AppImage output plugin built into it. The release asset never changes, so the pin stays valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The Linux build downloads
linuxdeploy-plugin-appimagefrom upstream'scontinuousrelease and checks it against a pinned SHA-256. Upstream's scheduled CI rebuilds that asset on the 1st of every month, so every Linux package build fails from then until the pin is updated by hand. The next break is November 1.What changed
scripts/appimage-host-libraries.mjsnow downloads the fixed linuxdeploy copy that Tauri's bundler pins, verifies it, unpacks it, and runs the AppImage output plugin built into it. Removing the bundled Wayland libraries before packing works the same as before.Source of the pinned file:
tauri-apps/binary-releases, releaselinuxdeploy-07333c6, assetlinuxdeploy-x86_64.AppImagemaster, commit07333c6e942c7d71782b66be924c5d867f9dfdfc, success), which builds the AppImage plugin from source and bundles itdevbranch pins the same release (LINUXDEPLOY_COMMIT_HASH = "07333c6")36a2d7e274d12e1050d0e9ecfe11d339ed54720b2bec464c286d53f8b07f5c62We don't host the plugin ourselves because it bundles GPL tools (
mksquashfsanddesktop-file-validate, via appimagetool).Checks
pnpm checkandpnpm testpass