Skip to content

Declare @rbxts/compiler-types as peer dependency - #1421

Open
christopher-buss wants to merge 1 commit into
roblox-ts:masterfrom
christopher-buss:fix/peer-deps
Open

christopher-buss wants to merge 1 commit into
roblox-ts:masterfrom
christopher-buss:fix/peer-deps

Conversation

@christopher-buss

Copy link
Copy Markdown
Contributor

Package uses types from @rbxts/compiler-types (via /// <reference types> and globals) but does not declare it in package.json.

With pnpm enableGlobalVirtualStore, each package resolves only its declared dependencies. @rbxts/compiler-types is not found and type checking fails. Current workaround in pnpm-workspace.yaml:

packageExtensions:
  "@rbxts/compiler-types":
    peerDependencies:
      "@rbxts/types": "*"
  "@rbxts/services":
    peerDependencies:
      "@rbxts/types": "*"
  "@rbxts/types":
    peerDependencies:
      "@rbxts/compiler-types": "*"

This PR adds "peerDependencies": { "@rbxts/compiler-types": "*" }. Companion PRs open in the other two repos.

🤖 Generated with Claude Code

Package references `@rbxts/compiler-types` types but does not declare it. Strict
resolvers (pnpm `enableGlobalVirtualStore`) cannot resolve it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant