Make boolean value tests stricter

subprojects/pyntcore/tests/test_api.py

@@ -4,10 +4,10 @@
 # works correctly
 #
 
-import pytest
-
 import logging
 
+import pytest
+
 logger = logging.getLogger("test")
 
 
@@ -124,7 +124,7 @@ def test_basic(nt_live):
 #         ct.put_boolean("foo", True)
 
 #     st = nt_server.get_table("t")
-#     assert st.get_boolean("foo", None) == True
+#     assert st.get_boolean("foo", None) is True
 
 #     # Client disconnect testing
 #     nt_client.shutdown()
@@ -135,7 +135,7 @@ def test_basic(nt_live):
 #         nt_client.start_test()
 #         ct = nt_client.get_table("t")
 
-#     assert ct.get_boolean("foo", None) == True
+#     assert ct.get_boolean("foo", None) is True
 
 #     # Server disconnect testing
 #     nt_server.shutdown()
@@ -150,4 +150,4 @@ def test_basic(nt_live):
 #         nt_server.start_test()
 
 #     st = nt_server.get_table("t")
-#     assert st.get_boolean("foo", None) == True
+#     assert st.get_boolean("foo", None) is True

subprojects/pyntcore/tests/test_network_table.py

@@ -24,9 +24,9 @@ def test_put_double(table1):
 
 def test_put_boolean(table1):
     table1.put_boolean("boolean", True)
-    assert table1.get_boolean("boolean", None) == True
+    assert table1.get_boolean("boolean", None) is True
 
-    assert table1.get_boolean("Non-Existent", False) == False
+    assert table1.get_boolean("Non-Existent", False) is False
 
 
 def test_put_string(table1):
@@ -60,8 +60,8 @@ def test_multi_data_type(table1):
     assert table1.get_number("double1", None) == 1
     assert table1.get_number("double2", None) == 2
     assert table1.get_number("double3", None) == 3
-    assert table1.get_boolean("bool1", None) == False
-    assert table1.get_boolean("bool2", None) == True
+    assert table1.get_boolean("bool1", None) is False
+    assert table1.get_boolean("bool2", None) is True
     assert table1.get_string("string1", None) == "String 1"
     assert table1.get_string("string2", None) == "String 2"
     assert table1.get_string("string3", None) == "String 3"
@@ -78,8 +78,8 @@ def test_multi_data_type(table1):
     assert table1.get_number("double1", None) == 4
     assert table1.get_number("double2", None) == 5
     assert table1.get_number("double3", None) == 6
-    assert table1.get_boolean("bool1", None) == True
-    assert table1.get_boolean("bool2", None) == False
+    assert table1.get_boolean("bool1", None) is True
+    assert table1.get_boolean("bool2", None) is False
     assert table1.get_string("string1", None) == "String 4"
     assert table1.get_string("string2", None) == "String 5"
     assert table1.get_string("string3", None) == "String 6"
@@ -90,17 +90,17 @@ def test_multi_table(table1, table2):
     table1.put_boolean("table1boolean", True)
     table1.put_string("table1string", "Table 1")
 
-    assert table2.get_number("table1double", None) == None
-    assert table2.get_boolean("table1boolean", None) == None
-    assert table2.get_string("table1string", None) == None
+    assert table2.get_number("table1double", None) is None
+    assert table2.get_boolean("table1boolean", None) is None
+    assert table2.get_string("table1string", None) is None
 
     table2.put_number("table2double", 2)
     table2.put_boolean("table2boolean", False)
     table2.put_string("table2string", "Table 2")
 
-    assert table1.get_number("table2double", None) == None
-    assert table1.get_boolean("table2boolean", None) == None
-    assert table1.get_string("table2string", None) == None
+    assert table1.get_number("table2double", None) is None
+    assert table1.get_boolean("table2boolean", None) is None
+    assert table1.get_string("table2string", None) is None
 
 
 # def test_get_table(nt, table1, table2):
@@ -162,15 +162,15 @@ def test_flags(table1):
 
 # def test_delete(table1):
 #     table1.put_boolean("foo", True)
-#     assert table1.get_boolean("foo", None) == True
+#     assert table1.get_boolean("foo", None) is True
 
 #     table1.delete("foo")
-#     assert table1.get_boolean("foo", None) == None
+#     assert table1.get_boolean("foo", None) is None
 
 
 def test_different_type(table1):
     assert table1.put_boolean("foo", True)
-    assert table1.get_boolean("foo", None) == True
+    assert table1.get_boolean("foo", None) is True
 
     assert not table1.put_number("foo", 1)
-    assert table1.get_boolean("foo", None) == True
+    assert table1.get_boolean("foo", None) is True

subprojects/pyntcore/tests/test_util.py

@@ -1,7 +1,7 @@
 import pytest
 
 from ntcore import NetworkTableInstance, NetworkTableType
-from ntcore.util import ntproperty, SelectableControl
+from ntcore.util import SelectableControl, ntproperty
 
 # def test_autoupdatevalue(nt):
 
@@ -10,19 +10,19 @@
 #     nt.shutdown()
 
 #     foo = nt.get_global_auto_update_value("/SmartDashboard/foo", True, True)
-#     assert foo.value == True
-#     assert foo.get() == True
+#     assert foo.value is True
+#     assert foo.get() is True
 
 #     nt.start_test_mode()
 
-#     assert foo.value == True
-#     assert foo.get() == True
+#     assert foo.value is True
+#     assert foo.get() is True
 
 #     t = nt.get_table("/SmartDashboard")
-#     assert t.get_boolean("foo", None) == True
+#     assert t.get_boolean("foo", None) is True
 #     t.put_boolean("foo", False)
 
-#     assert foo.value == False
+#     assert foo.value is False
 
 
 def test_ntproperty(nt: NetworkTableInstance):

subprojects/pyntcore/tests/test_value.py

@@ -4,20 +4,20 @@
 
 def test_value_bool():
     v = ntcore.Value.make_boolean(True)
-    assert v.get_boolean() == True
-    assert v.value() == True
+    assert v.get_boolean() is True
+    assert v.value() is True
 
 
 def test_mkvalue_bool():
     v = ntcore.Value.make_value(True)
-    assert v.get_boolean() == True
-    assert v.value() == True
+    assert v.get_boolean() is True
+    assert v.value() is True
 
 
 def test_bool_factory():
     f = ntcore.Value.get_factory_by_type(ntcore.NetworkTableType.BOOLEAN)
     v = f(True)
-    assert v.get_boolean() == True
+    assert v.get_boolean() is True
 
 
 def test_value_int():

subprojects/robotpy-wpiutil/tests/test_json.py

@@ -15,12 +15,12 @@ def test_json_invalid():
 
 
 def test_json_none():
-    assert cast_json_arg(None) == None
+    assert cast_json_arg(None) is None
 
 
 def test_json_bool():
-    assert cast_json_arg(True) == True
-    assert cast_json_arg(False) == False
+    assert cast_json_arg(True) is True
+    assert cast_json_arg(False) is False
 
 
 def test_json_int():