Repository navigation
Install MITTENS from PyPI wheels; no Rust toolchain needed - #21
Merged
Merged
Conversation
mittens-dmri 2.0.0a1 is on PyPI with prebuilt abi3 wheels for Linux, macOS and Windows, so MPAT no longer needs to pin it to GitHub and compile it with Rust and maturin. - Depend on mittens-dmri>=2.0.0a1; naming the pre-release lets pip pick it without --pre. - README and the install page drop the maturin/Rust step and point at rokemlab/MPAT. - CI drops the Rust toolchain, cache and maturin steps.
Contributor
|
I believe this needs a rebase to build cleanly on the CI |
- usage.md: pyAFQ moved its API pages; link ParticipantAFQ's new page. - conf.py: skip DOIs from AGU (10.1029) and SIAM (10.1137) in the link check. Those publishers answer automated requests with 403 Forbidden, though the DOIs resolve.
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing MPAT no longer needs a Rust toolchain.
MPAT itself is pure Python. The Rust came from its MITTENS v2 dependency, which MPAT pinned to the MITTENS GitHub repository, so pip compiled it from source with Rust and maturin.
mittens-dmriis now on PyPI (2.0.0a1) with prebuiltabi3wheels covering Python 3.10 and newer on:Changes
pyproject.toml: depends onmittens-dmri>=2.0.0a1instead of the GitHub URL. Naming the pre-release in the specifier lets pip install it without--pre.README and
docs/source/install.md:maturin/ Rust step;rokemlab/MPATinstead of36000/MPAT.CI (
test.yml,docs.yml): drop the Rust toolchain, Rust cache andmaturinsteps, which were only there to build MITTENS.Docs link check (also failing on
main):usage.mdlinksParticipantAFQ's new page, since pyAFQ moved its API pages;conf.pyskips DOIs from AGU (10.1029/) and SIAM (10.1137/). Those publishers answer automated requests with 403 Forbidden, although the DOIs resolve.Testing
pip install ".[test]"withPIP_ONLY_BINARY=mittens-dmriinstalled MITTENS from the wheel, without compiling.pytest testspasses against that install.PathTableon the 642-direction sphere,neighbor_offsets, andmittens.io(default_sphere,sh_basis_matrix,OdfData).This also lowers the bar for people trying MPAT through TRXViz 0.7.0. Its MPAT guide sends users to this install page.