Fix python call syntax highlighting

[pencels]

Summary

Fixes an issue with the Python lexer where any identifier used before an opening paren ( would be highlighted as a function name. This led to inconsistent highlighting in the case of for loops, where one for would be rendered as a keyword while the other was rendered as a function name:

This pull request also addresses other edge cases for call expressions:

• distinguishes Exception classes from normal classes in a call expr context
• distinguishes Builtin calls from identically named method calls

Visual Before and After

Before	After

[jneen]

@tancnle I've rebased this (had some conflicts) but it seems to have broken match/case. Would you mind taking a look?

[tancnle]

@jneen I have rebased and resolved the conflicts. Could you please have another look?

[jneen]

I might be mistaken, but wasn't this bug also fixed in 5.0.0?

live link: https://rouge.jneen.ca/v5.0.0/python/IyBLZXl3b3JkIHNob3VsZG4ndCBiZSByZWFkIGFzIGZ1bmN0aW9uIGNhbGwKZGVmIHRha2VfZmlyc3QocGFpcnMpOgogICAgZm9yIChmaXJzdCwgXykgaW4gcGFpcnM6CiAgICAgICAgeWllbGQgZmlyc3QKCiAgICBzZWxmLmZvcignbm9uc2Vuc2UnKQoKIyBEaXN0aW5ndWlzaCBiZXR3ZWVuIGJ1aWx0aW5zIGFuZCBtZXRob2QgY2FsbHMKc2VsZi5maWx0ZXIoZmlsdGVyKGxhbWJkYSB4OiB4ID09IDEsIGl0ZW1zKSk

[tancnle]

@jneen Good catch. I think the included example does not demonstrate the changes introduced by this branch correctly (item 2, 4). Also, I have noted that the changes have introduced some regressions (item 1, 3, 5).

No	Code	Old (main)	New (this branch)	Expected (need to fix)
1	raise ValueError("bad")	Name.Exception:"ValueError"	Name.Builtin:"ValueError"	Name.Exception:"ValueError"
2	raise MyCustomError("bad")	Name:"MyCustomError"	Name.Class:"MyCustomError"	Name.Class:"MyCustomError"
3	err = ValueError	Name.Exception:"ValueError"	Name.Builtin:"ValueError"	Name.Exception:"ValueError"
4	foo()	Name:"foo"	Name.Function:"foo"	Name.Function:"foo"
5	self.list	Name:"list"	Name.Builtin:"list"	Name:"list"

[jneen]

Hey Tan, Can you explain in your own words the meaning of this table and how you constructed it? To which changes are you referring? Which revisions are you referring to with "new" and "old"? The code on main is significantly newer than the code in this repository.

[tancnle]

@jneen I ran each of test example with rougify to compile the table.

❮ echo "self.list" | ./bin/rougify -l python -f null
Name "self"
Punctuation "."
Name "list"
Text "\n"

Which revisions are you referring to with "new" and "old"?

• New: 2ee8bfd
• Old: 5208dfa

To which changes are you referring?

Apology I could be more specific. I will need to submit another patch to point out the problematic parts.