Repository navigation
Release v0.3 - #5
Conversation
In-app updates and the Start with Windows check (#4). - CHANGELOG: 0.3 section, with the note that 0.2.x users install this version by hand once - README (both languages): the same note in the download steps - Version 0.3.0 Co-Authored-By: Claude <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewIncremental review of the five commits since the last review (toast wording, autostart fix, installer robustness). Toast: Files Reviewed (5 files)
Previous Review Summaries (2 snapshots, latest commit 3b58214)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3b58214)Status: No Issues Found | Recommendation: Merge OverviewIncremental review of the two post-#4 code fixes. Elevated-step release lookup: Files Reviewed (6 files)
Previous review (commit a98a7db)Status: No Issues Found | Recommendation: Merge OverviewRelease bookkeeping PR: CHANGELOG Files Reviewed (4 files)
Reviewed by glm-5.3 · Input: 49.9K · Output: 20K · Cached: 423.4K |
…ver from a vanished one Two findings from the Codex review of #4 that arrived after the merge: - The elevated step compared the zip only with the latest release. If a newer release came out between download and install, it refused, and DockSense came back offering the same download again. It now looks the digest up in the release list and accepts any release newer than the installed version. - A downloaded file that was deleted or quarantined was treated as a retryable I/O error, so every install attempt failed on the same missing file. It now counts as an invalid download: it is dropped and the release is offered for download again. When an update did not go in, the installer now starts the old version with --update-failed: the Status card says so, and the next check runs at the first tick. Co-Authored-By: Claude <noreply@anthropic.com>
- The Status card said "installs the next time DockSense starts" for a release that was only known, for example after the automatic download had failed, when the next start would install nothing. It now says so only once the download is there, and a failed automatic download is tried again every 30 minutes. - Whether the release zip is kept for the elevated step is decided when the download starts, not from the folder check at startup. - The installer no longer dies on a malformed path argument. - If a swap stops between its two renames, the installer puts the old file back under its real name before starting DockSense again. - The wait for the elevated swap is longer than that step can take; it still ends as soon as the elevated process is gone. - The "waits for the desktop" startup note needs Windows to report the full screen experience as supported, not only the registry key. Co-Authored-By: Claude <noreply@anthropic.com>
Merging this PR publishes DockSense v0.3 (tag
v0.3, x64 and ARM64 zips).Changelog: 0.3
What's in it
Both features came in with #4:
What this PR changes
--update-failed, and the Status card says so.The screenshots are unchanged: the first screen of every page looks the same for a normal install (the update card and the startup note only appear when they apply, and the Updates settings are below the fold).
Good to know
DockSense.exe(the old file is then next to it asDockSense.exe.old). Nothing can run to repair that by itself.Tested (on the ROG Xbox Ally X, see #4 for details)
With two single-file builds of different code, from this branch (d3e5e44):
--update-failed: the card shows the failure.dotnet build -c Releasewith 0 warnings, 130 unit tests pass.From 3b58214 (that code is unchanged since): the elevated step's logic, run without elevation. It accepted the real 0.2.1 release zip after checking it against the release list, and refused a zip that is not a release, a release that is not newer, and a missing zip.
Earlier, on #4: the real check and download of 0.2.1 with checksum verification, and the "another copy" startup note.
Not tested: the real UAC prompt end to end, a download that really is no longer the latest release (unit test only; there is no newer release yet), the retry of a failed automatic download, the update notification, the ARM64 build, how network failures look in the UI, and the clean-up of the mistaken key (the test machine has the full screen experience).
🤖 Generated with Claude Code