Skip to content

Release v0.3 - #5

Merged
rozx merged 3 commits into
mainfrom
release/v0.3
Nov 14, 2026
Merged

rozx merged 3 commits into
mainfrom
release/v0.3

Conversation

@rozx

@rozx rozx commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Merging this PR publishes DockSense v0.3 (tag v0.3, x64 and ARM64 zips).

Changelog: 0.3

What's in it

Both features came in with #4:

  • Updates from inside DockSense. A daily check against GitHub (can be turned off), a notification and a card on the Status page, and Install update. Install automatically downloads in the background and installs the next time DockSense starts. The download must match the size and SHA-256 GitHub publishes; in a protected folder the file swap asks for administrator approval and checks the download against GitHub again by itself.
  • Start with Windows tells you when it won't work. The switch shows what really happens at sign-in, with a note when Windows switched the entry off, the entry starts another copy, or Windows waits for the desktop in the full screen experience.
  • Fixed: on PCs without the Xbox full screen experience, 0.2.1 created its settings key, and DockSense then treated the feature as available.

What this PR changes

  • Release bookkeeping: the CHANGELOG section, the version bump to 0.3.0, and one line in the download steps of both READMEs.
  • Code fixes for review findings on Add in-app updates and a startup check #4 that arrived after it was merged. All 20 threads on Add in-app updates and a startup check #4 are resolved.
    • Codex (3b58214):
      • The elevated step compared the zip only with the latest release, so a download was refused once a newer release existed. It now looks the digest up in the release list and accepts any release newer than the installed version.
      • A downloaded file that was deleted or quarantined was retried forever. It is now dropped and the release is offered for download again.
      • When an update does not go in, the installer starts the old version with --update-failed, and the Status card says so.
    • Kilo (d3e5e44):
      • The card said "installs the next time DockSense starts" for a release that was only known (e.g. after a failed automatic download). It now says so only once the download is there, and a failed automatic download is retried every 30 minutes.
      • Whether the zip is kept for the elevated step is decided when the download starts, not from the folder check at startup.
      • The installer no longer dies on a malformed path argument, and it puts the old file back if a swap stopped between its two renames.
      • The wait for the elevated swap is longer than that step can take.
      • The "waits for the desktop" startup note needs Windows to report the full screen experience as supported, not only the registry key.

The screenshots are unchanged: the first screen of every page looks the same for a normal install (the update card and the startup note only appear when they apply, and the Updates settings are below the fold).

Good to know

  • 0.3 is the first version that can update itself, so 0.2.x users install it by hand once. The release notes and the READMEs say so.
  • The update from 0.3 to the next version will be the first real run of the installer, including the administrator prompt for copies in Program Files.
  • A power loss in the instant between the two renames of a swap can still leave the folder without DockSense.exe (the old file is then next to it as DockSense.exe.old). Nothing can run to repair that by itself.

Tested (on the ROG Xbox Ally X, see #4 for details)

With two single-file builds of different code, from this branch (d3e5e44):

  • Automatic install at startup and install from the Status card (also while paused).
  • A download that vanished before installing: it is dropped, and the card offers the release on GitHub again.
  • A start with --update-failed: the card shows the failure.
  • dotnet build -c Release with 0 warnings, 130 unit tests pass.

From 3b58214 (that code is unchanged since): the elevated step's logic, run without elevation. It accepted the real 0.2.1 release zip after checking it against the release list, and refused a zip that is not a release, a release that is not newer, and a missing zip.

Earlier, on #4: the real check and download of 0.2.1 with checksum verification, and the "another copy" startup note.

Not tested: the real UAC prompt end to end, a download that really is no longer the latest release (unit test only; there is no newer release yet), the retry of a failed automatic download, the update notification, the ARM64 build, how network failures look in the UI, and the clean-up of the mistaken key (the test machine has the full screen experience).

🤖 Generated with Claude Code

In-app updates and the Start with Windows check (#4).

- CHANGELOG: 0.3 section, with the note that 0.2.x users install this
  version by hand once
- README (both languages): the same note in the download steps
- Version 0.3.0

Co-Authored-By: Claude <noreply@anthropic.com>
@rozx rozx added the release Merging this PR from release/vX.Y publishes a GitHub release label Nov 14, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T01:22:03.807793Z d3e5e44 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kilo-code-bot

kilo-code-bot Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

Incremental review of the five commits since the last review (toast wording, autostart fix, installer robustness). Toast: InstallsAtNextStart was split into InstallsWithoutAsking (automatic, writable folder, installable) and InstallsAtNextStart (the former plus a verified staged download); the toast keeps the un-split meaning, which is correct because UpdateFound only fires for a newly seen release, when nothing is staged yet — the split property would otherwise always read false there and permanently show the wrong toast. Status card: reordering the switch so the automatic message wins over Ready matches the new staged requirement, and _updates.Error ?? takes precedence over the message, so the automatic-mode Upd_AvailableMessage ("restarts itself") is only a transient flash between check and download — never shown during a persistent download failure. Automatic download retry: the 30-minute timer tick retries a failed background download only when the mode is Automatic and the stage is still Available; _busy prevents overlap, Off/Notify are excluded, and Available always implies a fresh offer with an asset. Elevation: recomputing NeedsElevation/CanWriteInstallFolder at download time (instead of startup) makes keepZip match what Begin will decide; a permission flip between the two is still handled by Begin's zip check and the drop-and-re-offer path. Installer: raising ElevatedSwapTimeout to 5 minutes correctly covers 30 s GitHub + 60 s exit wait + copy (the old 90 s left zero margin); moving Path.GetFullPath/relaunch building inside the try turns bad-path argument crashes into a logged failure; and the new .old restore only runs when the target is missing and the old file exists, so it cannot undo a completed swap, and its failure modes degrade exactly as before the change (no relaunch either way). Autostart: requiring FullScreenExperience.IsSupported alongside the registry key correctly extends the 0.2.1 mistaken-key fix (WaitsForDesktop can no longer be true on PCs without the feature). CLAUDE.md ("never restarts itself unasked") and the CHANGELOG ("downloaded in the background and installed the next time DockSense starts") remain accurate for the new behavior.

Files Reviewed (5 files)
  • src/DockSense.App/App.xaml.cs
  • src/DockSense.App/Platform/AutoStart.cs
  • src/DockSense.App/Platform/UpdateInstaller.cs
  • src/DockSense.App/Services/UpdateService.cs
  • src/DockSense.App/ViewModels/MainViewModel.cs
Previous Review Summaries (2 snapshots, latest commit 3b58214)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 3b58214)

Status: No Issues Found | Recommendation: Merge

Overview

Incremental review of the two post-#4 code fixes. Elevated-step release lookup: IsNewerRelease now fetches the release list and FindRelease matches the zip's SHA-256 against any listed release newer than the installed version (not only the latest), reusing Offer's asset validation (arch suffix, digest present, size bounds, repo download URL); rate-limit/non-array JSON safely yields an empty list and a refusal, and digest comparison is case-insensitive. Gone downloads: Begin treats a missing staged file as InvalidDataException, so InstallAsync drops it and re-offers the release; the startup path already drops it via Validate/CleanUp. --update-failed: appended only when the install did not go in; the relaunched old version also receives --after-update, which correctly suppresses TryInstallAtStartup (preventing a startup retry loop) and enables the mutex wait, while --update-failed sets the card error (verified the Status card binds Error first) and forces a check at the first timer tick that deliberately bypasses the daily-schedule and failure-retry gates. RelaunchArguments() rebuilds its list, so the flag cannot accumulate across restarts. Background checks no longer clear a shown error — only user actions do — which matches the documented intent. CLAUDE.md and CHANGELOG statements match the new behavior, localization keys exist in both languages, and the new xUnit tests assert the right cases (newer-release-exists, non-newer, wrong architecture, unknown digest, non-list JSON). No bugs, security issues, gaps, or misleading docs found in the changed lines.

Files Reviewed (6 files)
  • CLAUDE.md
  • src/DockSense.App/App.xaml.cs
  • src/DockSense.App/Platform/UpdateInstaller.cs
  • src/DockSense.App/Services/UpdateService.cs
  • src/DockSense.Core/Updates.cs
  • tests/DockSense.Core.Tests/UpdatesTests.cs

Previous review (commit a98a7db)

Status: No Issues Found | Recommendation: Merge

Overview

Release bookkeeping PR: CHANGELOG 0.3 section, version bump to 0.3.0, and a download-step note in both READMEs. Verified for accuracy, consistency, and gaps: the CHANGELOG link ref matches the v0.3 tag pattern and repo convention (previous releases converted Unreleased the same way); ReleaseVersion.Format renders 0.3.0 as 0.3, so the About page, tag, and CHANGELOG stay consistent; no other files hardcode the old 0.2.1 version; both README notes mirror each other and the zh-CN term 设置 → 更新 matches the app's Set_Updates resource string; README features, roadmap, and config table were already updated in #4, so nothing is missing for this release.

Files Reviewed (4 files)
  • CHANGELOG.md
  • Directory.Build.props
  • README.md
  • README.zh-CN.md

Reviewed by glm-5.3 · Input: 49.9K · Output: 20K · Cached: 423.4K

rozx and others added 2 commits November 13, 2026 20:13
…ver from a vanished one

Two findings from the Codex review of #4 that arrived after the merge:

- The elevated step compared the zip only with the latest release. If a
  newer release came out between download and install, it refused, and
  DockSense came back offering the same download again. It now looks the
  digest up in the release list and accepts any release newer than the
  installed version.
- A downloaded file that was deleted or quarantined was treated as a
  retryable I/O error, so every install attempt failed on the same
  missing file. It now counts as an invalid download: it is dropped and
  the release is offered for download again.

When an update did not go in, the installer now starts the old version
with --update-failed: the Status card says so, and the next check runs at
the first tick.

Co-Authored-By: Claude <noreply@anthropic.com>
- The Status card said "installs the next time DockSense starts" for a
  release that was only known, for example after the automatic download
  had failed, when the next start would install nothing. It now says so
  only once the download is there, and a failed automatic download is
  tried again every 30 minutes.
- Whether the release zip is kept for the elevated step is decided when
  the download starts, not from the folder check at startup.
- The installer no longer dies on a malformed path argument.
- If a swap stops between its two renames, the installer puts the old
  file back under its real name before starting DockSense again.
- The wait for the elevated swap is longer than that step can take; it
  still ends as soon as the elevated process is gone.
- The "waits for the desktop" startup note needs Windows to report the
  full screen experience as supported, not only the registry key.

Co-Authored-By: Claude <noreply@anthropic.com>
@rozx
rozx merged commit a3f18f6 into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Merging this PR from release/vX.Y publishes a GitHub release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant