Repository navigation
Release v0.3.2 - #7
Conversation
Changing the iGPU memory between modes took "unplug, wait for the mode change, then restart", because the new size is only written once the new mode is detected. - Tray menu: "Restart for <mode> (<size>)" for each other mode whose profile size differs from the one in effect (IgpuRestartPlanner). After a confirmation dialog it stores that size and restarts Windows, so the user switches modes while the PC restarts. - The "Restart to apply the iGPU memory" toast has a "Restart now" button. It restarts only while a size is still pending: Windows starts DockSense for a click on an old toast, and that must not restart the PC. - The toast is removed once nothing is pending any more. - SystemPower.Restart replaces the inline shutdown.exe call. Co-Authored-By: Claude <noreply@anthropic.com>
Changelog, both READMEs (feature list and the iGPU memory FAQ) and the version bump for the tray's "Restart for <mode>" and the toast's "Restart now" button. Co-Authored-By: Claude <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental review of commits
Files Re-reviewed (5 files)
Notes: read-only review — unit tests and the release build were not executed. The other 10 files of this PR are unchanged since the previous review; their previous findings are all covered by the fixes above. Previous Review Summary (commit 3de3669)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3de3669)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (15 files)
Notes: read-only review — unit tests and the release build were not executed. Verified clean during review: toast activation routing (button vs body), Reviewed by glm-5.3 · Input: 43.5K · Output: 11.5K · Cached: 401.4K |
- A restart that was asked for but did not happen (shutdown.exe could not be started, or the user cancelled at Windows' blocking-apps screen) left the other mode's size stored without a word. DockSense now shows the pending-restart notification when it is still running 30 seconds later, or at once when the restart could not be requested. - "Already stored" only skips the write when the firmware was just read successfully; after a failed read the cached value may be out of date. - The confirmation text read "stores Auto of iGPU memory" for a profile set to Auto; it now says "sets the iGPU memory to Auto". Co-Authored-By: Claude <noreply@anthropic.com>
The "may exist" flag was cleared before the removal ran, so one failed removal left the stale notification in place for the rest of the session. The flag is now cleared only after the removal succeeded, and a failure is logged once instead of at every status change. Co-Authored-By: Claude <noreply@anthropic.com>
Merging this PR publishes release v0.3.2 (the
releaselabel and the branch name trigger the release workflow).Release notes: CHANGELOG 0.3.2
Highlights
Switching modes with a different iGPU memory size now takes one restart instead of "unplug, wait, then restart".
Changes
IgpuRestartPlanner(Core, 5 new unit tests): which modes are worth restarting for.DockSenseService.PrepareIgpuRestart,Platform/SystemPower, tray menu items, toast button and its activation handling.Tested
🤖 Generated with Claude Code