Skip to content

Release v0.3.3 - #8

Merged
rozx merged 5 commits into
mainfrom
release/v0.3.3
Nov 19, 2026
Merged

rozx merged 5 commits into
mainfrom
release/v0.3.3

Conversation

@rozx

@rozx rozx commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Merging this PR publishes v0.3.3 (tag, both zips and the GitHub release). Notes: CHANGELOG 0.3.3.

Why

Windows runs the per-user Run key late. Measured on the Ally X from the event logs:

Boot Sign-in Shell DockSense launched
Into the full screen experience 19:47:54.7 19:47:58 19:48:31 (+36 s)
Desktop 19:51:30.1 19:51:36.3 19:52:53 (+83 s)

Shut down as a handheld and switched on at the eGPU, Windows booted into the full screen experience and DockSense left it 50 s after sign-in. In the desktop boot, other apps' logon-triggered tasks started at 19:51:31.9, about 4 s before explorer.exe.

What changes

  • Start with Windows also registers a per-user logon task DockSense-<SID> (no admin). The Run entry stays as the setting and the fallback: the task only starts DockSense while Windows would start the Run entry too, and the second of the two starts exits without opening the window.
  • A start at sign-in writes the current mode's StartupToGamingHome before any UI is loaded.
  • The live full screen switch at startup waits until 20 s after sign-in, instead of 10 s after DockSense started.
  • Restart for <mode> also stores that mode's sign-in setting.
  • The tray icon is retried until the taskbar exists.

Tested on the Ally X (docked to the XG Mobile)

  • 153 unit tests pass; Release build has 0 warnings.
  • Task Scheduler accepts the task XML (ITaskService.NewTask(0).XmlText, nothing registered), and the same late-bound COM calls read an existing per-user logon task and report a missing one. Also from the single-file build (--probe).
  • Sign-in fast path: 238–259 ms after process start in a single-file Release build, 114 ms in a Debug build.
  • A second --autostart start exits with 0 and does not open the window. A --logon-task start exits when the Run entry is for another copy.
  • On a desktop without a taskbar (CreateDesktop), DockSense keeps running and retries the tray icon. Before this change that start was aborted.

Not tested yet

  • Registering the task from DockSense. Only the XML and the read path ran; RegisterTask itself has not.
  • A real sign-in. Whether the task starts DockSense about 2 s after sign-in, whether the early write beats the shell's read of StartupToGamingHome, and whether the tray icon appears once the taskbar is up.
  • Whether Armoury Crate's plan switches during boot stay under the re-assert limit (5 in 2 minutes) now that DockSense is up first.

The log line Sign-in start in <mode> mode: Full Screen Experience at sign-in -> off (… ms after DockSense started, … s after sign-in) shows the result of the first sign-in.

🤖 Generated with Claude Code

rozx and others added 2 commits November 18, 2026 20:32
…e first

Windows runs the HKCU Run key late: 33 s after the shell when booting into
the full screen experience, 83 s after sign-in on the desktop. A PC shut
down as a handheld and switched on at the eGPU therefore booted into the
full screen experience and DockSense left it 50 s after sign-in.

- "Start with Windows" also registers a per-user logon task
  (DockSense-<SID>, no admin). Logon tasks start about 2 s after sign-in,
  some 4 s before explorer.exe. The Run entry stays as the setting and the
  fallback; the task only starts DockSense while Windows would start the
  Run entry too, and the second of the two starts exits silently.
- A start at sign-in writes the mode's StartupToGamingHome before any UI
  is loaded (about 250 ms after process start in a single-file build).
- The live switch at startup waits until 20 s after sign-in instead of
  10 s after DockSense started.
- "Restart for <mode>" stores that mode's sign-in setting as well.
- The tray icon is retried until the taskbar exists: before the shell is
  up, Shell_NotifyIcon fails and the startup would have been aborted.

Not yet verified at a real sign-in: registering the task from DockSense
and whether the early write beats the shell's read.

Co-Authored-By: Claude <noreply@anthropic.com>
Changelog, both READMEs (sign-in task, the full screen experience at
sign-in, uninstall) and the version bump.

Co-Authored-By: Claude <noreply@anthropic.com>
@rozx rozx added the release Merging this PR from release/vX.Y publishes a GitHub release label Nov 19, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T02:01:30.716493Z d93f5de New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Started by the sign-in task, DockSense applies the profile about 3 s after
sign-in, before explorer.exe exists. Programs with "when DockSense starts"
and notifications (a restart is needed, warnings) would have gone out into
a session without a desktop. They now wait until 20 s after sign-in, the
same point the live full screen switch waits for. The wait sits in the
program queue, so a mode change meanwhile keeps its place behind it.

Co-Authored-By: Claude <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4507acc48a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/DockSense.App/Services/Toasts.cs Resolved
Codex review of #8: a restart notification raised before the shell is up
is held until 20 s after sign-in. If the restart stopped being needed in
that time, clearing found nothing to remove and marked the toast as gone,
and the held one was still published afterwards and stayed.

Showing and clearing now share a request counter: a held toast only goes
out while its own request is still the latest.

Co-Authored-By: Claude <noreply@anthropic.com>
Comment thread src/DockSense.App/Platform/AutoStart.cs Resolved
Comment thread src/DockSense.App/Platform/AutoStart.cs Resolved
Comment thread CHANGELOG.md Resolved
Comment thread CLAUDE.md Resolved
@kilo-code-bot

kilo-code-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Incremental review of 94885e7..d93f5de. All four previous findings verified fixed: ReadStatus() now distinguishes an unreadable registry (task left untouched on start and in settings), DisabledByWindows is logged as its own case, and both doc notes (CHANGELOG 20 s switch precondition, CLAUDE.md ShellWait vs FsePlanner.StartupDelay) now match the code.

Files Reviewed (3 files)
  • CHANGELOG.md
  • CLAUDE.md
  • src/DockSense.App/Platform/AutoStart.cs
Previous Review Summary (commit 94885e7)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 94885e7)

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 4
Issue Details (click to expand)

SUGGESTION

File Line Issue
src/DockSense.App/Platform/AutoStart.cs 127 A failed registry read is treated as Off and permanently deletes the sign-in task
src/DockSense.App/Platform/AutoStart.cs 131 Log misreports DisabledByWindows as "leaving the start to Windows"
CHANGELOG.md 16 The 20 s FSE fallback-switch bullet omits the "switch immediately" precondition
CLAUDE.md 132 Note says the live FSE switch waits for ShellWait, but it uses FsePlanner.StartupDelay
Files Reviewed (20 files)
  • CHANGELOG.md - 1 issue
  • CLAUDE.md - 1 issue
  • Directory.Build.props
  • README.md
  • README.zh-CN.md
  • src/DockSense.App/App.xaml.cs
  • src/DockSense.App/DockSenseService.cs
  • src/DockSense.App/Localization/Strings.resx
  • src/DockSense.App/Localization/Strings.zh-Hans.resx
  • src/DockSense.App/Platform/AutoStart.cs - 2 issues
  • src/DockSense.App/Platform/DeviceProbe.cs
  • src/DockSense.App/Platform/LogonTaskRegistration.cs
  • src/DockSense.App/Platform/SignInSession.cs
  • src/DockSense.App/ProbeReport.cs
  • src/DockSense.App/Program.cs
  • src/DockSense.App/Services/Toasts.cs
  • src/DockSense.App/Services/TrayIconService.cs
  • src/DockSense.App/SignInFastPath.cs
  • src/DockSense.App/ViewModels/MainViewModel.cs
  • src/DockSense.Core/FsePlanner.cs
  • src/DockSense.Core/LogonTaskDefinition.cs
  • src/DockSense.Core/StartupEntry.cs
  • tests/DockSense.Core.Tests/FsePlannerTests.cs
  • tests/DockSense.Core.Tests/LogonTaskDefinitionTests.cs
  • tests/DockSense.Core.Tests/StartupEntryTests.cs

Notes: The earlier held-restart-toast defect (Codex comment on Toasts.cs:181) is fixed by head commit 94885e7's request counter and was not re-reported. The WTS_INFO_CLASS value 24 (WTSSessionInfo → WTSINFOW, LogonTime at offset 200, size 216) and the struct arithmetic in SignInSession.cs were verified correct against the Windows SDK enum.


Reviewed by glm-5.3 · Input: 38K · Output: 5K · Cached: 251.4K

- A registry read that fails no longer counts as "Start with Windows is
  off" where that removes the sign-in task: a task start then exits
  without cleaning up, and the settings switch leaves the task alone.
- The log says why a task start exited: switched off in Windows and held
  back until the desktop in Xbox mode are separate messages now.
- Changelog: the switch 20 s after sign-in needs "switch immediately".
- CLAUDE.md: the live switch waits through FsePlanner.StartupDelay, not
  SignInSession.ShellWait; the two differ when the sign-in time is unknown.

Co-Authored-By: Claude <noreply@anthropic.com>
@rozx
rozx merged commit 673510f into main Nov 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Merging this PR from release/vX.Y publishes a GitHub release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant