Repository navigation
Release v0.3.3 - #8
Conversation
…e first Windows runs the HKCU Run key late: 33 s after the shell when booting into the full screen experience, 83 s after sign-in on the desktop. A PC shut down as a handheld and switched on at the eGPU therefore booted into the full screen experience and DockSense left it 50 s after sign-in. - "Start with Windows" also registers a per-user logon task (DockSense-<SID>, no admin). Logon tasks start about 2 s after sign-in, some 4 s before explorer.exe. The Run entry stays as the setting and the fallback; the task only starts DockSense while Windows would start the Run entry too, and the second of the two starts exits silently. - A start at sign-in writes the mode's StartupToGamingHome before any UI is loaded (about 250 ms after process start in a single-file build). - The live switch at startup waits until 20 s after sign-in instead of 10 s after DockSense started. - "Restart for <mode>" stores that mode's sign-in setting as well. - The tray icon is retried until the taskbar exists: before the shell is up, Shell_NotifyIcon fails and the startup would have been aborted. Not yet verified at a real sign-in: registering the task from DockSense and whether the early write beats the shell's read. Co-Authored-By: Claude <noreply@anthropic.com>
Changelog, both READMEs (sign-in task, the full screen experience at sign-in, uninstall) and the version bump. Co-Authored-By: Claude <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Started by the sign-in task, DockSense applies the profile about 3 s after sign-in, before explorer.exe exists. Programs with "when DockSense starts" and notifications (a restart is needed, warnings) would have gone out into a session without a desktop. They now wait until 20 s after sign-in, the same point the live full screen switch waits for. The wait sits in the program queue, so a mode change meanwhile keeps its place behind it. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4507acc48a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review of #8: a restart notification raised before the shell is up is held until 20 s after sign-in. If the restart stopped being needed in that time, clearing found nothing to remove and marked the toast as gone, and the held one was still published afterwards and stayed. Showing and clearing now share a request counter: a held toast only goes out while its own request is still the latest. Co-Authored-By: Claude <noreply@anthropic.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental review of Files Reviewed (3 files)
Previous Review Summary (commit 94885e7)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 94885e7)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (20 files)
Notes: The earlier held-restart-toast defect (Codex comment on Reviewed by glm-5.3 · Input: 38K · Output: 5K · Cached: 251.4K |
- A registry read that fails no longer counts as "Start with Windows is off" where that removes the sign-in task: a task start then exits without cleaning up, and the settings switch leaves the task alone. - The log says why a task start exited: switched off in Windows and held back until the desktop in Xbox mode are separate messages now. - Changelog: the switch 20 s after sign-in needs "switch immediately". - CLAUDE.md: the live switch waits through FsePlanner.StartupDelay, not SignInSession.ShellWait; the two differ when the sign-in time is unknown. Co-Authored-By: Claude <noreply@anthropic.com>
Merging this PR publishes v0.3.3 (tag, both zips and the GitHub release). Notes: CHANGELOG 0.3.3.
Why
Windows runs the per-user Run key late. Measured on the Ally X from the event logs:
Shut down as a handheld and switched on at the eGPU, Windows booted into the full screen experience and DockSense left it 50 s after sign-in. In the desktop boot, other apps' logon-triggered tasks started at 19:51:31.9, about 4 s before
explorer.exe.What changes
DockSense-<SID>(no admin). The Run entry stays as the setting and the fallback: the task only starts DockSense while Windows would start the Run entry too, and the second of the two starts exits without opening the window.StartupToGamingHomebefore any UI is loaded.<mode>also stores that mode's sign-in setting.Tested on the Ally X (docked to the XG Mobile)
ITaskService.NewTask(0).XmlText, nothing registered), and the same late-bound COM calls read an existing per-user logon task and report a missing one. Also from the single-file build (--probe).--autostartstart exits with 0 and does not open the window. A--logon-taskstart exits when the Run entry is for another copy.CreateDesktop), DockSense keeps running and retries the tray icon. Before this change that start was aborted.Not tested yet
RegisterTaskitself has not.StartupToGamingHome, and whether the tray icon appears once the taskbar is up.The log line
Sign-in start in <mode> mode: Full Screen Experience at sign-in -> off (… ms after DockSense started, … s after sign-in)shows the result of the first sign-in.🤖 Generated with Claude Code