Repository navigation
fix(cli): restore zsh tab completion after installation - #337
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh zsh sessions could not complete even
rssh <Tab>after CLI installation: the installer wrote_rsshbut never loaded it. The dynamic registration script also skipped completion on the first Tab when loaded throughfpath.Initialize completion when needed and source the installed script from an idempotent
.zshrcblock. Preserve existing configuration and resolve the effectiveZDOTDIRthrough zsh's.zshenv, including GUI launches without that environment variable. Report installation failures, while allowing successful shell startup diagnostics. Make the generated script support both sourcing and first-call autoload completion using the existing Clap callback.Add real zsh regression coverage and install zsh in the PR and release test jobs so those tests execute in CI. Isolate test fpath to stock zsh functions and private nested fixture directories, preserving compaudit permission checks without depending on runner-specific site-functions or shared /tmp permissions.
Entry points
.zshrcor open a new shell.rssh completions zshsupports both source andfpathloading, reusing existing dynamic candidates.Validation
npm test: 1,402 tests passed;npm run buildpassed.cargo fmt --all --checkandcargo test --workspace --all-features: 1,011 tests passed, one existing doctest ignored.rssh <Tab>listed subcommands andrssh prof<Tab>completed torssh profile.