Skip to content

feat(ui): separate edit target selection and navigation - #338

Merged
shihuili1218 merged 2 commits into
mainfrom
feat/edit-target-session-navigation
Nov 13, 2026
Merged

shihuili1218 merged 2 commits into
mainfrom
feat/edit-target-session-navigation

Conversation

@shihuili1218

@shihuili1218 shihuili1218 commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Edit target cards now use a checkbox in the upper-right corner to choose broadcast recipients. Clicking the preview or label switches to the target's workspace and focuses its exact pane, including nested splits and the root pane when another pane was previously focused.

The controls use the existing checkbox theme and workspace/pane store actions. Cards have thin themed borders, 8px padding and spacing, and a subtle hover border. The checkbox hit area is transparent, without a separate rounded background, while retaining a 44px click target and localized accessible labels. Navigation preserves the editor and broadcast selection, clears the hover preview, and keeps the target list as the scroll owner.

Entry points

  • Desktop GUI: supported; verified selection, navigation, selection persistence and split-pane focus in a macOS debug app. Also launched npm run tauri -- dev.
  • Mobile GUI: the same buttons and checkboxes remain available; verified the shared frontend at 390 × 844 with mouse and keyboard, including Space/Enter. Physical mobile touch testing was not performed.
  • CLI: N/A, UI interaction only; no data or command changes.
  • Headless / JetBrains: supported by the shared frontend with no new IPC commands/events. Verified local PTY sessions, nested split navigation, root-pane focus and selection persistence through node idea-plugin/scripts/dev-browser.mjs.

Validation

  • npm test: 122 files, 1407 tests passed, including five new DOM tests using the real app store and editor.
  • npm run build
  • cargo fmt --all --check
  • cargo test --workspace --all-features: 1004 tests passed; one existing doc-test ignored.
  • cargo check -p rssh-app --features server --bin rssh-server
  • Independent code review completed before each push; no blocking findings.
  • Final card border/background styling visually verified in the headless browser. Native screenshot capture was unavailable for this CSS follow-up; the macOS interaction checks above cover the unchanged selection/navigation behavior.
  • Rust unit tests passed; doc-tests passed on a separate rerun after concurrent packaging caused missing-crate errors.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 15:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T15:23:34.482861Z 87d5794 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@shihuili1218
shihuili1218 merged commit 7398d0c into main Nov 13, 2026
2 checks passed
@shihuili1218
shihuili1218 deleted the feat/edit-target-session-navigation branch November 13, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants