Repository navigation
feat(ui): separate edit target selection and navigation - #338
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit target cards now use a checkbox in the upper-right corner to choose broadcast recipients. Clicking the preview or label switches to the target's workspace and focuses its exact pane, including nested splits and the root pane when another pane was previously focused.
The controls use the existing checkbox theme and workspace/pane store actions. Cards have thin themed borders, 8px padding and spacing, and a subtle hover border. The checkbox hit area is transparent, without a separate rounded background, while retaining a 44px click target and localized accessible labels. Navigation preserves the editor and broadcast selection, clears the hover preview, and keeps the target list as the scroll owner.
Entry points
npm run tauri -- dev.node idea-plugin/scripts/dev-browser.mjs.Validation
npm test: 122 files, 1407 tests passed, including five new DOM tests using the real app store and editor.npm run buildcargo fmt --all --checkcargo test --workspace --all-features: 1004 tests passed; one existing doc-test ignored.cargo check -p rssh-app --features server --bin rssh-server