Repository navigation
fix(terminal): preserve touch input while dragging selection handles - #341
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
旧版 Android WebView 在拖动原生选区手柄时不会发送新的 DOM pointerdown,却可能把后续 contextmenu 标记为 mouse。现有判断让这个标记覆盖此前记录的触摸来源,导致 RSSH 自定义菜单或右键复制/粘贴动作介入选字。
保留最近一次真实 touch/pen 输入,直到实际鼠标按下或键盘输入切换来源;仅收到合成的 mouse contextmenu 不再覆盖触摸状态。系统选字手柄及“复制/粘贴/打开 Chrome”等原生工具条继续保留,Tab 长按菜单独立保留。
对应上游问题:Chromium #41487195。Chromium 的修复提交也确认了原生手柄合成菜单的 pointerType 问题;此处兼容尚未包含该修复的 WebView。
入口影响:
验证:
npm test:123 个文件、1422 项测试通过。npm run build、git diff --check通过。浏览器验证重放的是已知的 WebView 事件序列,未模拟 Android 原生蓝色手柄或系统工具条。当前环境缺少 Rust/Cargo,未完成原生客户端启动及 Android 真机验证。