Skip to content

fix(ci): populate AGC release notes from GitHub releases - #342

Merged
shihuili1218 merged 1 commit into
mainfrom
fix/agc-release-notes
Nov 14, 2026
Merged

shihuili1218 merged 1 commit into
mainfrom
fix/agc-release-notes

Conversation

@shihuili1218

Copy link
Copy Markdown
Collaborator

AGC rejects HarmonyOS upgrades with 204144692 / 请补充新版本特性 when the release draft has no new version features. Read the matching stable tag's GitHub Release description before compilation, including drafts. Trim the text and automatically truncate it to 500 characters without splitting a surrogate pair; missing or empty descriptions stop the job before building.

After the uploaded package finishes parsing, update only the existing default language's newFeatures, then read it back and verify the app name, description and short description were preserved before submitting review. Keep other languages unchanged. Review failures now include bounded, redacted ret.msg diagnostics; submission is still never retried automatically.

GitHub requires push access to read draft releases, so the HarmonyOS job and its reusable-workflow caller receive contents: write. The notes script only sends GET requests, and checkout does not persist credentials. The original GitHub Release body is unchanged. A matching release description must exist before the HarmonyOS job starts; the desktop jobs' empty draft alone is insufficient.

Entry points:

  • Desktop GUI: runtime unchanged; the HarmonyOS desktop package uses the updated release pipeline.
  • Mobile GUI: runtime unchanged; the HarmonyOS phone/tablet package uses the same pipeline.
  • CLI: the upload script accepts AGC_RELEASE_NOTES_FILE; direct callers without it keep the existing behavior. The application CLI is unchanged.
  • Headless / JetBrains: no runtime, command or event changes.

Validation:

  • Release notes, upload and version preparation tests: 138 passed.
  • npm test: 1,415 passed.
  • npm run build: passed.
  • cargo fmt --all --check: passed.
  • cargo test --workspace --all-features: 1,011 passed, 1 doctest ignored.
  • git diff --check: passed.
  • Full npm run test:build encountered one existing signing-restoration failure on this Mac. The unchanged test also fails in isolation because Apple Python 3.9.6 lacks the required tar extraction filter APIs; 18 Linux-specific tests were skipped.

No live AGC upload or review submission was performed.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 07:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T07:45:56.862676Z 273cfbb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@shihuili1218
shihuili1218 merged commit 88db7cb into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants