Repository navigation
fix(ci): populate AGC release notes from GitHub releases - #342
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGC rejects HarmonyOS upgrades with
204144692/请补充新版本特性when the release draft has no new version features. Read the matching stable tag's GitHub Release description before compilation, including drafts. Trim the text and automatically truncate it to 500 characters without splitting a surrogate pair; missing or empty descriptions stop the job before building.After the uploaded package finishes parsing, update only the existing default language's
newFeatures, then read it back and verify the app name, description and short description were preserved before submitting review. Keep other languages unchanged. Review failures now include bounded, redactedret.msgdiagnostics; submission is still never retried automatically.GitHub requires push access to read draft releases, so the HarmonyOS job and its reusable-workflow caller receive
contents: write. The notes script only sends GET requests, and checkout does not persist credentials. The original GitHub Release body is unchanged. A matching release description must exist before the HarmonyOS job starts; the desktop jobs' empty draft alone is insufficient.Entry points:
AGC_RELEASE_NOTES_FILE; direct callers without it keep the existing behavior. The application CLI is unchanged.Validation:
npm test: 1,415 passed.npm run build: passed.cargo fmt --all --check: passed.cargo test --workspace --all-features: 1,011 passed, 1 doctest ignored.git diff --check: passed.npm run test:buildencountered one existing signing-restoration failure on this Mac. The unchanged test also fails in isolation because Apple Python 3.9.6 lacks the required tar extraction filter APIs; 18 Linux-specific tests were skipped.No live AGC upload or review submission was performed.