Repository navigation
docs(git): 明訂 trunk-based 工作流與 GPG 簽章守門 - #92
Merged
Merged
Conversation
要求 dev 先以既有金鑰簽章 rebase 到最新 main,禁止多餘 merge commit,並在整合時保留提交與簽章。 補充最新 SHA 的 CI 驗證、精確 force-with-lease、合併後立即對齊 dev,以及平台規則衝突時的停止條件。
成對繪製自訂回饋背景與文字,修正高對比配色及系統色變更後的殘留,保留尺寸、內距與必要的主題重啟提示。 統一輸入框與預設按鈕的情境提示色,加入對比襯底;新增實際像素、焦點與進度條對比、色覺紋理及按下亮度差回歸測試,並同步 UI CI 與工程文件。 驗證:三種主題各 14/14、完整 UI 25/25、非 UI 456/456;Release 建置 0 警告與錯誤,修改檔案資訊級診斷為空。
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Focused-hover styling can lose contrast, Space-key presses lack visual feedback, and the disabled-text contrast test can pass even when the text is missing.
3 open issues
焦點重新套色會覆蓋懸停外觀並降低對比 · New Space 鍵按壓未反映於按鈕視覺狀態 · New 停用按鈕的裝飾斜線會造成空白文字對比檢查誤判 · New
What changed in this PR
此 PR 明訂 InputBox 的 trunk-based Git 工作流與 GPG 簽章守門,同時調整 .NET 11 按鈕視覺回饋、對比提示及 UI 回歸測試。
Changes:
- 規範簽章 rebase、最新提交的 CI 驗證、保留簽章的整合方式及合併後立即對齊
dev。 - 自繪按鈕互動背景與文字,共用焦點情境選色,並為預設動作邊框加入對比襯底。
- 新增 14 項按鈕渲染測試,同步測試文件、無障礙規範及 CI 路徑篩選。
| File | Description |
|---|---|
| tests/InputBox.Tests/README.md | 更新測試數量與按鈕配色驗證紀錄。 |
| tests/InputBox.Tests/ButtonFeedbackRenderingTests.cs | 新增互動狀態、配色還原及像素對比測試。 |
| src/InputBox/MainForm.Events.cs | 共用焦點選色並重繪預設動作提示。 |
| src/InputBox/Core/Extensions/ControlExtensions.cs | 新增情境選色與邊框對比襯底支援。 |
| src/InputBox/Core/Extensions/ButtonEyeTrackerExtensions.cs | 自繪互動表面並處理系統色更新。 |
| docs/engineering/git-commit-safety.md | 明訂線性歷史、簽章及 PR 整合守門。 |
| docs/engineering/a11y-safety.md | 補充預設動作對比與像素驗證要求。 |
| .github/workflows/ci.yml | 將按鈕渲染相關檔案納入 UI 測試路徑篩選。 |
Review effort: Balanced
系統色更新時保留焦點與懸停組合,分離滑鼠與 Space 按壓狀態,並在按鍵放開及失焦時清理,不攔截原生點擊。 停用文字改以空白基準排除裝飾與動畫像素,新增無文字反例及組合狀態回歸測試。完整 UI 34/34、非 UI 456/456,深色與高對比各 23/23,建置 0 警告與錯誤,資訊級診斷為空。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

明訂 dev 的簽章 rebase、禁止多餘 merge commit、整合時保留提交與 GPG 簽章,以及 PR 合併後立即對齊 main。
補充最新 SHA 的 CI 守門、精確 force-with-lease 與平台規則衝突時的停止條件。
驗證:git diff --check、本機 git verify-commit 與 GitHub GPG 簽章驗證均通過。僅文件異動,建置與 UI 測試依既有 CI 路徑篩選判定。此草稿 PR 用於確認 CI,本次不合併。