Repository navigation
fix(ui): 修正 Blink 結束後殘留的警示框色 - #93
Merged
Merged
Conversation
還原輸入區配色及焦點提示後,重繪控制項與子控制項的非客戶區框架,清除 .NET 11 Latest 留下的警示舊色;共用對話框亦套用相同還原處理,保留焦點、選取範圍與版面。 新增 Blink 完成、取消及有無焦點的螢幕像素回歸測試,並納入 UI CI 路徑判斷。已完成 v0.0.69 與 v0.0.71 三種主題的截圖比較;非 UI 456 項及 UI 38 項通過,Release 建置零警告、零錯誤,資訊層級格式與分析器檢查皆無診斷。
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human confirmation is needed because the fix relies on .NET 11 native non-client painting whose visual results could not be independently validated across Windows themes and DPI settings.
No open issues 🎉
What changed in this PR
此 PR 修正 .NET 11 Latest 文字框在 Blink 完成或取消後殘留警示框色的問題。還原配色與焦點提示後,明確重繪客戶區及非客戶區,並將相同處理套用至共用對話框。
Changes:
- 新增遞迴框架重繪方法與 Win32 呼叫,不重建 HWND 或改變輸入狀態及版面。
- 在主視窗、片語編輯及數值輸入對話框的 Blink 還原流程中套用重繪。
- 新增四項螢幕像素回歸測試,涵蓋完成/取消及有/無焦點,並更新 UI CI 路徑判斷與測試文件。
| File | Description |
|---|---|
tests/InputBox.Tests/README.md |
更新測試數量並記錄像素回歸與驗證結果。 |
tests/InputBox.Tests/BlinkFrameRenderingTests.cs |
新增四項框架像素及輸入狀態保留測試。 |
src/InputBox/MainForm.Events.cs |
主視窗還原 Blink 視覺後重繪輸入框架。 |
src/InputBox/Core/Interop/User32.Redraw.cs |
新增 RedrawWindow 宣告及重繪旗標。 |
src/InputBox/Core/Extensions/ControlExtensions.cs |
新增控制項樹遞迴框架重繪方法。 |
src/InputBox/Core/Controls/PhraseEditDialog.A11y.cs |
片語編輯對話框還原警示後重繪框架。 |
src/InputBox/Core/Controls/NumericInputDialog.A11y.cs |
數值輸入對話框還原焦點提示後重繪框架。 |
.github/workflows/ci.yml |
將新增測試檔納入 UI CI 路徑判斷。 |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正 Blink 結束或取消後,.NET 11 Latest 文字框非客戶區殘留警示色的問題。還原配色與焦點提示後重繪框架,保留 HWND、選取範圍、焦點與版面;共用對話框一併套用。
新增四項螢幕像素回歸測試並納入 UI CI 路徑判斷。已比較 v0.0.69、原版 v0.0.71 與修正版在淺色、深色、高對比下 Blink 前/中/後的實際截圖。
本機驗證:非 UI 456/456、UI 38/38;三種主題新增測試各 4/4;Release 建置零警告、零錯誤,修改 C# 的資訊層級格式與分析器診斷皆為空。使用既有 GPG 金鑰簽章並驗證。